-
Notifications
You must be signed in to change notification settings - Fork 204
fix: compiler crashes when a contract name exceeds filesystem limits #3219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hazyone
wants to merge
3
commits into
tact-lang:main
Choose a base branch
from
hazyone:fix/3138
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
import { sha256_sync } from "@ton/crypto"; | ||
import path from "path"; | ||
|
||
/** | ||
* Ensures the resulting file name does not exceed the given maximum length. | ||
* If too long, trims the name and appends a short hash to avoid collisions. | ||
* | ||
* @param name - The base file name without extension. | ||
* @param ext - The file extension. | ||
* @param maxLen - Maximum allowed length for the full file name (default: 255). | ||
* @returns A safe file name within the specified length. | ||
*/ | ||
export const makeSafeName = ( | ||
name: string, | ||
ext: string, | ||
maxLen = 255, | ||
): string => { | ||
const full = name + ext; | ||
|
||
if (full.length <= maxLen) { | ||
return full; | ||
} | ||
|
||
const hash = sha256_sync(Buffer.from(name)).toString("hex").slice(0, 8); | ||
const suffix = `_${hash}${ext}`; | ||
const maxNameLen = maxLen - suffix.length; | ||
const safeName = name.slice(0, maxNameLen); | ||
|
||
return `${safeName}${suffix}`; | ||
}; | ||
|
||
/** | ||
* Returns the full extension of a file, including all parts after the first dot. | ||
* - "file.txt" => ".txt" | ||
* - "archive.tar.gz" => ".tar.gz" | ||
*/ | ||
export const getFullExtension = (filename: string): string => { | ||
const base = path.basename(filename); | ||
const firstDotIndex = base.indexOf("."); | ||
return firstDotIndex !== -1 ? base.slice(firstDotIndex) : ""; | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2^32 hashes are still possible to mine, possibly creating a name clash
I think it would rather be better to just err whenever
len(projectName) + len(contractName) + 1 >= 255
, or evenlen(projectName) > 100 || len(contractName) > 100
.These are not the kind of situations that might happen in non-malicious code, and emitting an error would be completely fine.