Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. 📝 Walkthrough요약새로운 모듈 세 개(도착 시간 추적, 게임 흐름 선택기, 결과 표시)를 도입하고 이들을 활용하도록 create-game-app.ts를 대폭 리팩토링합니다. 마블의 도착 시간 추적, 완료 상태 기반 애니메이션 템포 조정, 결과 UI 상태 관리를 중앙화합니다. 변경 사항
시퀀스 다이어그램sequenceDiagram
participant Game as 게임 상태
participant Tracker as 도착 추적기
participant Tension as 완료 긴장도
participant Result as 결과 표시
participant UI as UI 업데이트
Game->>Tracker: begin(시작시간, 초기시뮬시간)
Game->>Tension: getFinishTensionSnapshot(마블목록, 월드높이)
Tension->>Game: {active, remaining, progress}
Game->>Game: getFinishTempoMultiplier(기본값, snapshot)
Note over Game: 템포 조정 적용
Game->>Tracker: capture(현재시간, 시뮬시간, 완료된마블목록)
Tracker->>Tracker: 벽시간/시뮬시간 혼합으로 도착시간 추정
Game->>Result: buildResultStateFromItems(아이템목록, 요청수)
Result->>Result: resolveResultPhase(아이템) → "single"/"summary"
Result->>Result: 상태전이: idle → spinning → single
Game->>UI: resultState 업데이트
UI->>UI: 결과 화면 렌더링
예상 코드 리뷰 노력🎯 4 (복잡) | ⏱️ ~45분 관련 가능 PR
✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 사항
src/app/create-game-app.ts에서 순수 도메인 로직/결과 상태 전이/도착 시간 추적 로직을 분리해 조립자 역할 중심으로 정리했습니다.src/app/game-flow-selectors.ts: 상태 파생/클램프/문자열 정규화/피니시 템포 계산(순수 함수)src/app/result-presentation.ts: 결과 모달 상태 전이 및 결과 아이템 매핑(순수 함수)src/app/arrival-timing-tracker.ts: 도착 시간 추적 상태 캡슐화tests/game-flow-selectors.test.mjstests/result-presentation.test.mjstests/arrival-timing-tracker.test.mjs검증
Summary by CodeRabbit
릴리스 노트
새로운 기능
테스트