Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings from Rust 1.80 by rely on docsrs --cfg provided by docs.rs #747

Merged
merged 1 commit into from
May 25, 2024

Conversation

Mingun
Copy link
Collaborator

@Mingun Mingun commented May 25, 2024

Serde maintainer say that docs.rs defines --cfg=docsrs when building documentation: serde-rs/serde#2745

Fixes new warning: https://blog.rust-lang.org/2024/05/06/check-cfg.html

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.90%. Comparing base (5d76174) to head (3996459).
Report is 13 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #747      +/-   ##
==========================================
+ Coverage   61.24%   61.90%   +0.66%     
==========================================
  Files          39       39              
  Lines       16277    16520     +243     
==========================================
+ Hits         9969    10227     +258     
+ Misses       6308     6293      -15     
Flag Coverage Δ
unittests 61.90% <100.00%> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dralley dralley merged commit 5fd130a into tafia:master May 25, 2024
6 checks passed
@Mingun Mingun deleted the fix-rust1.80-warns branch May 25, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants