create tag api의 PathVariable에 memberId를 추가한다

tag-wonder · Nov 6, 2023 · df0b046 · df0b046
1 parent d3770c2
commit df0b046
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/api/src/main/kotlin/org/tagwonder/controllers/TagController.kt b/api/src/main/kotlin/org/tagwonder/controllers/TagController.kt
@@ -19,12 +19,14 @@ class TagController(
     private val createTagsCommandExecutor: CreateTagsCommandExecutor,
     private val getTagsQueryProcessor: GetTagsQueryProcessor
 ) {
-    @PostMapping("/tags")
+    @PostMapping("/members/{memberId}/tags")
     fun createTags(
+        @PathVariable("memberId") memberId: Long,
         @RequestBody command: CreateTagsCommand
     ) {
         try {
             createTagsCommandExecutor.execute(
+                memberId = memberId,
                 command = command
             )
         } catch (e: InvalidCommandException) {

diff --git a/contracts/src/main/kotlin/org/tagwonder/commands/CreateTagsCommand.kt b/contracts/src/main/kotlin/org/tagwonder/commands/CreateTagsCommand.kt
@@ -2,5 +2,4 @@ package org.tagwonder.commands
 
 data class CreateTagsCommand(
     val titles: List<String>,
-    val memberId: Long
 )
diff --git a/domain-model/src/main/kotlin/org/tagwonder/usecases/commands/CreateTagsCommandExecutor.kt b/domain-model/src/main/kotlin/org/tagwonder/usecases/commands/CreateTagsCommandExecutor.kt
@@ -10,22 +10,22 @@ import org.tagwonder.usecases.utils.hasDuplicate
 class CreateTagsCommandExecutor(
     private val tagRepository: ITagRepository
 ) {
-    fun execute(command: CreateTagsCommand) {
+    fun execute(memberId: Long, command: CreateTagsCommand) {
         validCommand(command)
-        existsTitleInTag(command)
+        existsTitleInTag(memberId, command.titles)
         tagRepository.creates(
             command.titles.map {
                 Tag(
                     title = it,
-                    memberId = command.memberId
+                    memberId = memberId
                 )
             }
         )
     }
 
-    private fun existsTitleInTag(command: CreateTagsCommand) {
-        command.titles.forEach {
-            tagRepository.find(command.memberId, it)?.let {
+    private fun existsTitleInTag(memberId: Long, titles: List<String>) {
+        titles.forEach {
+            tagRepository.find(memberId, it)?.let {
                 throw InvalidRequestException("title already exists")
             }
         }