🪄 [QA] Update stage environments #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Make input component handle value changes with bigints not strings. Adjust components using the `TokenAmountInput` to new format.
`bigIntToDisplayUserAmount` should be able to display nice label for values smaller than desired precision, let's make it to show the smallest possible number like: `<0.01` for desired precision `2` etc.
Allow using "Max" button and don't allow the input to override the real value with stringified value with less precision.
Added "step=any" to hide the tooltip on the "number" input
Closes #607 #### What else should be done - [x] Setting the correct animation for bubbles. - [x] If possible, add animations for `RealmsBar`. `RealmBarIcon` should move more smoothly when the population is changed. - [ ] After joining the realm, show a bubble instantly. - [ ] Improve intervals for realms. - [x] Adding bubble to the modal window. ### What The app should be more lively. This PR adds +1 bubble over a realm every time somebody joins. The bubble should be visible over the realm on the map but also in the modal window. The population is fetched from the contracts every minute. We shouldn't show 20 bubbles at the same time and then not show anything for 1 minute. We should spread out the number of bubbles we show. - So let's add a variable `displayedPopulation` to increment it and show the bubbles with the correct interval. - Intervals should be different for the realms to make the app more lively. - When we init game data, we should refresh the `displayedPopulation` and align it with the true number. ### Testing Let's use a patch file to increase the population and do tests. Use the following file: [increase-population.patch](https://github.com/tahowallet/dapp/files/13249010/increase-population.patch) The population is increased randomly every minute. ``` git apply increase-population.patch ``` - [ ] When a user joins the region, a bubble should show up immediately in the modal. - [ ] Bubbles should occur at different intervals between realms. - [ ] After refreshing the page, the population should show the correct number.
✅ Deploy Preview for taho-development ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Resolves #694 ### Problem We have been using floating point numbers to transform bigints to strings with 18 decimal places. But it was easy to mess up the precision because bigints were larger than max safe int. We need a way to be able to work in the inputs with both very large and very small numbers. ### What has been done Make input component handle value changes with bigints not strings. Adjust components using the `TokenAmountInput` to new format. - show nicely small balances (`<0,0001 TAHO`) - `bigIntToDisplayUserAmount` should be able to display nice label for values smaller than desired precision, let's make it to show the smallest possible number like: `<0.01` for desired precision `2` etc. - Allow using "Max" button and don't allow the input to override the real value with stringified value with less precision. - Add util to display bigints as strings with max precision  ### Testing To test it please use stake and unstake forms. Type some value or click "max" and try to unstake/stake - check the value that is displayed on the wallet token allowance screen (make sure you don't have any allowance set on the TAHO or veTAHO on that account so you'll be able to test it that way) - [x] test it with super small amounts (up to 18 decimal places) - [x] test it with big amounts (for example >=3301 TAHO) - [x] test it with big amounts with some values on decimal places (`3000.0000000001`)
Copy of #677
andreachapman
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request that upon merging will update stage environments with recent
mainchanges.The environments that will be updated:
Read more: Deployment to Production Flow