Skip to content

Commit

Permalink
Fix typos (#3724)
Browse files Browse the repository at this point in the history
Fix typos

Latest build:
[extension-builds-3724](https://github.com/tahowallet/extension/suites/19459096494/artifacts/1143984843)
(as of Tue, 02 Jan 2024 21:25:22 GMT).
  • Loading branch information
Shadowfiend authored Apr 13, 2024
2 parents 4a93eba + a846085 commit 44222c4
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
10 changes: 5 additions & 5 deletions rfb/rfb-3-multinetwork-dapp-connections.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ Default account and network: The global current address and current network shou

When connecting to a dApp the chainID needs to be set on the window-provider. The default network should be used for this.

When permission is granted the default address and chain should be used if given permission. If not, then the first the was granted.
When permission is granted the default address and chain should be used if given permission. If not, then the first was granted.

❗️The user can change networks e.g. on uniswap before granting permission but there is no way for us to know what it is and the dApp follows what the wallet sets on window-provider. So we can use the default value as active connection when permission is granted.

Expand Down Expand Up @@ -156,11 +156,11 @@ Our internal dApps — swap, send etc — will use the global account and networ

- User changes network or account in the global selector
- `setNewSelectedSelectedAddressOnNetwork` is dispatched
- ⚠️ note: We don't make the distinction here whether the account or the network was changed. This information will be important in the `window-provider` but it will take care of it in it's own scope.
- ⚠️ note: We don't make the distinction here whether the account or the network was changed. This information will be important in the `window-provider` but it will take care of it in its own scope.
- redux is updated for every dApp that has been granted permission
- in main we update the [uiSliceEmitter > newAddressOnNetwork listener](https://github.com/tallycash/extension/blob/0c12499d711290a0de9f28898be44f87fe6d664f/background/main.ts#L1110)
- persist the change in `InternalEthereumProvider` for every dApp that has been granted permission
- notify the content scripts for every dApp that has an live connection / open port
- notify the content scripts for every dApp that has a live connection / open port
- check referrals

###### Incoming RPC call augmentation flow
Expand All @@ -169,7 +169,7 @@ Every incoming RPC call from the dApps should be augmented with the information
This will be done in `InternalEthereumProvider` when calling `ChainService` as an additional argument for the method calls.

‼️ Security concern:
Based on the [ethereum JSON RPC APIs spec](https://github.com/ethereum/execution-apis) calls that have transactions as a parameter have the chainID. We need to validate, that the call param is the same as one that the user has selected.
Based on the [ethereum JSON RPC APIs spec](https://github.com/ethereum/execution-apis) calls that have transactions as a parameter have the chainID. We need to validate, that the call param is the same as the one that the user has selected.

These are the following methods:

Expand All @@ -189,7 +189,7 @@ These are the following methods:

- > Permissions are network bound or not (the question here is: do we need to track different permissions by network, or only by address?).
- [Decision thread](https://www.flowdock.com/app/cardforcoin/tally-product-design/threads/GKW_YsOIDVoqoo9LV4fx5RIwHDh)
- Permissions are network bound, we need to be able differentiate between networks
- Permissions are network bound, we need to be able to differentiate between networks
- it’s possible to have permission for `0xdeadbeef` on mainnet but not on polygon
- it's possible to have permission for `0xdeadbeef` on mainnet and polygon but not on arbitrum
- > The question of whether the current network is synced between a dApp and the extension popover (the question here is: do internal dApps need the same model to handle this as external dApps?).
Expand Down
8 changes: 4 additions & 4 deletions rfb/rfb-5-control-compatile-addresses.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ The Taho wallet was built with the intent of supporting not only multiple
networks, but multiple networks that might be of different types (e.g.,
non-EVM). This was a core design strategy, but it's often the case that
ongoing development can deprioritize certain thinking that maintains the
underlying flexibility needed to rerpesent these differences.
underlying flexibility needed to represent these differences.

Currently, the code base assumes that a given address is always controlled by
the same underlying key, keyring, or external device, even if it is on a
Expand Down Expand Up @@ -118,9 +118,9 @@ another network:
| Private key import | Polygon | Yes | Private key |
| Private key import | RSK | Yes | Private key |
| Private key import | BTC | No | Address format |
| Ledger walllet | Polygon | Yes | Tx compatible |
| Ledger walllet | RSK | Yes | Tx compatible |
| Ledger walllet | BTC | No | Address format |
| Ledger wallet | Polygon | Yes | Tx compatible |
| Ledger wallet | RSK | Yes | Tx compatible |
| Ledger wallet | BTC | No | Address format |
| WalletConnect Safe[^5] | Polygon | No | Tx incompatible |
| WalletConnect Safe | RSK | No | Tx incompatible |
| WalletConnect Safe | BTC | No | Address format |
Expand Down

0 comments on commit 44222c4

Please sign in to comment.