Skip to content

Conversation

@L2ncE
Copy link

@L2ncE L2ncE commented Jun 8, 2023

Hi, I am adding the release tests of taichi Course01 for Taichi.

There will be some deprecated methods in taichi_sph that need to be replaced.

Copy link

@ltt1598 ltt1598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the deprecated APIs.
The changes look good to me.

@L2ncE L2ncE marked this pull request as draft June 8, 2023 09:06
@L2ncE L2ncE force-pushed the fix/remove_deprecated_func branch from 6c7f3f7 to f4e37e2 Compare June 8, 2023 09:08
@L2ncE L2ncE force-pushed the fix/remove_deprecated_func branch from f4e37e2 to 7ed9eab Compare June 8, 2023 09:08
@L2ncE L2ncE marked this pull request as ready for review June 8, 2023 09:08
@L2ncE
Copy link
Author

L2ncE commented Jun 8, 2023

Thanks for fixing the deprecated APIs. The changes look good to me.

There was an indentation problem just now, it has been fixed now~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants