Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kit): Number should ignore [decimalSeparator] value if [precision]=0 #1908

Merged
merged 2 commits into from
Dec 26, 2024
Merged

fix(kit): Number should ignore [decimalSeparator] value if [precision]=0 #1908

merged 2 commits into from
Dec 26, 2024

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Dec 24, 2024 •
edited
Loading 

const options = maskitoNumberOptionsGenerator({ thousandSeparator: '.' });

maskitoTransform('123.456', options) // 123 ❌

Fixes #1907

@nsbarsukov nsbarsukov self-assigned this Dec 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 24, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 33e335a):

https://maskito--pr1908-number-zero-precisio-9eh30aqb.web.app

(expires Fri, 27 Dec 2024 08:00:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 61e4dea776cbea516b68c67840913d2edd88bb90

@nsbarsukov nsbarsukov marked this pull request as ready for review December 24, 2024 13:09
@nsbarsukov nsbarsukov requested a review from a team as a code owner December 24, 2024 13:09
@nsbarsukov nsbarsukov requested review from MarsiBarsi, waterplea, vladimirpotekhin and mdlufy and removed request for a team December 24, 2024 13:09
@github-actions github-actions bot added the ready to merge ready label Dec 25, 2024
@nsbarsukov nsbarsukov merged commit 19effe2 into main Dec 26, 2024
31 checks passed
@nsbarsukov nsbarsukov deleted the number-zero-precision-ignore-decimal-separator branch December 26, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

Assignees

@nsbarsukov nsbarsukov

Labels
ready to merge ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - Number should ignore [decimalSeparator] value if [precision]=0
2 participants
@nsbarsukov @waterplea