error[E0061]: this function takes 7 arguments but 6 arguments were supplied --> halo2_proofs/benches/plonk.rs:284:9 | 284 | create_proof::<IPACommitmentScheme<EqAffine>, ProverIPA<EqAffine>, _, _, _, _>( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 285 | params, 286 | pk, | -- an argument of type `&halo2_proofs::poly::ipa::commitment::ParamsIPA<halo2curves::pasta::EqAffine>` is missing | note: expected `&[&[&[Fp]]]`, found `&[MyCircuit<Fp>; 1]` --> halo2_proofs/benches/plonk.rs:287:13 | 287 | &[circuit], | ^^^^^^^^^^ = note: expected reference `&[&[&[halo2curves::pasta::Fp]]]` found reference `&[criterion_benchmark::MyCircuit<halo2curves::pasta::Fp>; 1]` note: expected `&mut _`, found `OsRng` --> halo2_proofs/benches/plonk.rs:289:13 | 289 | rng, | ^^^ = note: expected mutable reference `&mut _` found struct `rand_core::OsRng` note: function defined here --> /home/runner/work/halo2/halo2/halo2_proofs/src/plonk/prover.rs:45:8 | 45 | pub fn create_proof< | ^^^^^^^^^^^^ help: consider mutably borrowing here | 289 | &mut rng, | ++++ help: provide the argument | 284 | create_proof::<IPACommitmentScheme<EqAffine>, ProverIPA<EqAffine>, _, _, _, _>(params, /* &halo2_proofs::poly::ipa::commitment::ParamsIPA<halo2curves::pasta::EqAffine> */, pk, &[&[]], /* &[&[&[halo2curves::pasta::Fp]]] */, &mut transcript, /* transcript */) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error[E0277]: the trait bound `halo2_proofs::transcript::Blake2bWrite<std::vec::Vec<u8>, halo2curves::pasta::EqAffine, halo2_proofs::transcript::Challenge255<halo2curves::pasta::EqAffine>>: rand_core::RngCore` is not satisfied --> halo2_proofs/benches/plonk.rs:290:18 | 284 | create_proof::<IPACommitmentScheme<EqAffine>, ProverIPA<EqAffine>, _, _, _, _>( | ------------------------------------------------------------------------------ required by a bound introduced by this call ... 290 | &mut transcript, | ^^^^^^^^^^ the trait `rand_core::RngCore` is not implemented for `halo2_proofs::transcript::Blake2bWrite<std::vec::Vec<u8>, halo2curves::pasta::EqAffine, halo2_proofs::transcript::Challenge255<halo2curves::pasta::EqAffine>>` | = help: the following other types implement trait `rand_core::RngCore`: rand_chacha::chacha::ChaCha20Rng rand_core::block::BlockRng<R> rand_core::block::BlockRng64<R> rand_chacha::chacha::ChaCha12Rng rand_core::OsRng std::boxed::Box<R> rand_chacha::chacha::ChaCha8Rng rand::rngs::adapter::read::ReadRng<R> and 5 others = note: required for `&mut Blake2bWrite<Vec<u8>, EqAffine, Challenge255<EqAffine>>` to implement `rand_core::RngCore` = note: the full type name has been written to '/home/runner/work/halo2/halo2/target/debug/deps/plonk-3eb5c01c16c3260a.long-type-13791201337578202080.txt' note: required by a bound in `halo2_proofs::plonk::create_proof` --> /home/runner/work/halo2/halo2/halo2_proofs/src/plonk/prover.rs:50:8 | 45 | pub fn create_proof< | ------------ required by a bound in this function ... 50 | R: RngCore, | ^^^^^^^ required by this bound in `create_proof`

error[E0277]: the trait bound `&[_; 0]: halo2_proofs::plonk::Circuit<halo2curves::pasta::Fp>` is not satisfied --> halo2_proofs/benches/plonk.rs:288:13 | 284 | create_proof::<IPACommitmentScheme<EqAffine>, ProverIPA<EqAffine>, _, _, _, _>( | ------------------------------------------------------------------------------ required by a bound introduced by this call ... 288 | &[&[]], | ^^^^^^ the trait `halo2_proofs::plonk::Circuit<halo2curves::pasta::Fp>` is not implemented for `&[_; 0]` | = help: the trait `halo2_proofs::plonk::Circuit<F>` is implemented for `criterion_benchmark::MyCircuit<F>` note: required by a bound in `halo2_proofs::plonk::create_proof` --> /home/runner/work/halo2/halo2/halo2_proofs/src/plonk/prover.rs:52:22 | 45 | pub fn create_proof< | ------------ required by a bound in this function ... 52 | ConcreteCircuit: Circuit<Scheme::Scalar>, | ^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `create_proof`

error[E0277]: the trait bound `halo2_proofs::poly::ipa::commitment::ParamsIPA<halo2curves::pasta::EqAffine>: halo2curves::zal::MsmAccel<halo2curves::pasta::EqAffine>` is not satisfied --> halo2_proofs/benches/plonk.rs:285:13 | 285 | params, | ^^^^^^ the trait `halo2curves::zal::MsmAccel<halo2curves::pasta::EqAffine>` is not implemented for `halo2_proofs::poly::ipa::commitment::ParamsIPA<halo2curves::pasta::EqAffine>` | = help: the trait `halo2curves::zal::MsmAccel<C>` is implemented for `halo2curves::zal::H2cEngine` = note: required for the cast from `&halo2_proofs::poly::ipa::commitment::ParamsIPA<halo2curves::pasta::EqAffine>` to `&dyn halo2curves::zal::MsmAccel<halo2curves::pasta::EqAffine>`

Clippy had exited with the 101 exit code

error: usage of `Iterator::fold` on a type that implements `Try` --> halo2_proofs/src/dev.rs:1842:30 | 1842 | ... .fold(Ok(()), |acc, res| acc.and(res)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold((), |acc, res| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `-D clippy::manual-try-fold` implied by `-D warnings`

error: useless conversion to the same type: `I` --> halo2_proofs/src/dev.rs:953:60 | 953 | let mut inputs: Vec<(Vec<_>, usize)> = lookup_input_row_ids | ____________________________________________________________^ 954 | | .clone() 955 | | .into_iter() | |____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into_iter()` | 953 ~ let mut inputs: Vec<(Vec<_>, usize)> = lookup_input_row_ids 954 + .clone() |

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/dev.rs:798:32 | 798 | .chain(blinding_rows.into_iter())) | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `blinding_rows` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: useless conversion to the same type: `I` --> halo2_proofs/src/dev.rs:795:22 | 795 | (gate_row_ids | ______________________^ 796 | | .clone() 797 | | .into_iter() | |____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into_iter()` | 795 ~ (gate_row_ids 796 + .clone() |

error: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:296:33 | 296 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:253:33 | 253 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:222:33 | 222 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-D clippy::default-constructed-unit-structs` implied by `-D warnings`

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:218:22 | 218 | .zip(inv_denoms.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `inv_denoms` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:203:14 | 203 | .zip(assigned_denominators.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `assigned_denominators` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly/ipa/multiopen/prover.rs:117:62 | 117 | let (p_poly, p_poly_blind) = q_polys.into_iter().zip(q_blinds.into_iter()).fold( | ^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `q_blinds` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: useless conversion to the same type: `std::slice::ChunksMut<'_, bool>` --> halo2_proofs/src/plonk.rs:227:37 | 227 | for (bits, byte) in selector.chunks_mut(8).into_iter().zip(selector_bytes) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `selector.chunks_mut(8)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:376:25 | 376 | / lookups 377 | | .iter() 378 | | .flat_map(move |p| p.queries(vk, x)) 379 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 376 ~ lookups 377 + .iter() 378 ~ .flat_map(move |p| p.queries(vk, x)), |

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:310:25 | 310 | / lookups 311 | | .iter() 312 | | .zip(vk.cs.lookups.iter()) 313 | | .flat_map(move |(p, argument)| { ... | 327 | | }) 328 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 310 ~ lookups 311 + .iter() 312 + .zip(vk.cs.lookups.iter()) 313 + .flat_map(move |(p, argument)| { 314 + p.expressions( 315 + l_0, 316 + l_last, 317 + l_blind, 318 + argument, 319 + theta, 320 + beta, 321 + gamma, 322 + advice_evals, 323 + fixed_evals, 324 + instance_evals, 325 + challenges, 326 + ) 327 ~ }), |

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:679:24 | 679 | .chain(lookups.iter().flat_map(move |p| p.open(pk, x)).into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookups.iter().flat_map(move |p| p.open(pk, x))` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: useless conversion to the same type: `std::ops::Range<usize>` --> halo2_proofs/src/plonk/vanishing/prover.rs:59:50 | 59 | let mut thread_seeds: Vec<ChaCha20Rng> = (0..num_chunks) | __________________________________________________^ 60 | | .into_iter() | |________________________^ help: consider removing `.into_iter()`: `(0..num_chunks)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:2005:22 | 2005 | .zip(degrees.into_iter()) | ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `degrees` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:1556:18 | 1556 | .zip(self.constraints.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `self.constraints` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: useless conversion to the same type: `std::ops::Range<i32>` --> halo2_proofs/src/fft.rs:74:17 | 74 | let a = (0..(1 << max_log_n)) | _________________^ 75 | | .into_iter() | |________________________^ help: consider removing `.into_iter()`: `(0..(1 << max_log_n))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings`

error: useless conversion to the same type: `I` --> halo2_proofs/src/dev.rs:953:60 | 953 | let mut inputs: Vec<(Vec<_>, usize)> = lookup_input_row_ids | ____________________________________________________________^ 954 | | .clone() 955 | | .into_iter() | |____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into_iter()` | 953 ~ let mut inputs: Vec<(Vec<_>, usize)> = lookup_input_row_ids 954 + .clone() |

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/dev.rs:798:32 | 798 | .chain(blinding_rows.into_iter())) | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `blinding_rows` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: useless conversion to the same type: `I` --> halo2_proofs/src/dev.rs:795:22 | 795 | (gate_row_ids | ______________________^ 796 | | .clone() 797 | | .into_iter() | |____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into_iter()` | 795 ~ (gate_row_ids 796 + .clone() |

error: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:296:33 | 296 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:253:33 | 253 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:222:33 | 222 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-D clippy::default-constructed-unit-structs` implied by `-D warnings`

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:218:22 | 218 | .zip(inv_denoms.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `inv_denoms` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:203:14 | 203 | .zip(assigned_denominators.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `assigned_denominators` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly/ipa/multiopen/prover.rs:117:62 | 117 | let (p_poly, p_poly_blind) = q_polys.into_iter().zip(q_blinds.into_iter()).fold( | ^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `q_blinds` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: useless conversion to the same type: `std::slice::ChunksMut<'_, bool>` --> halo2_proofs/src/plonk.rs:227:37 | 227 | for (bits, byte) in selector.chunks_mut(8).into_iter().zip(selector_bytes) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `selector.chunks_mut(8)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:376:25 | 376 | / lookups 377 | | .iter() 378 | | .flat_map(move |p| p.queries(vk, x)) 379 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 376 ~ lookups 377 + .iter() 378 ~ .flat_map(move |p| p.queries(vk, x)), |

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:310:25 | 310 | / lookups 311 | | .iter() 312 | | .zip(vk.cs.lookups.iter()) 313 | | .flat_map(move |(p, argument)| { ... | 327 | | }) 328 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 310 ~ lookups 311 + .iter() 312 + .zip(vk.cs.lookups.iter()) 313 + .flat_map(move |(p, argument)| { 314 + p.expressions( 315 + l_0, 316 + l_last, 317 + l_blind, 318 + argument, 319 + theta, 320 + beta, 321 + gamma, 322 + advice_evals, 323 + fixed_evals, 324 + instance_evals, 325 + challenges, 326 + ) 327 ~ }), |

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:679:24 | 679 | .chain(lookups.iter().flat_map(move |p| p.open(pk, x)).into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookups.iter().flat_map(move |p| p.open(pk, x))` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: useless conversion to the same type: `std::ops::Range<usize>` --> halo2_proofs/src/plonk/vanishing/prover.rs:59:50 | 59 | let mut thread_seeds: Vec<ChaCha20Rng> = (0..num_chunks) | __________________________________________________^ 60 | | .into_iter() | |________________________^ help: consider removing `.into_iter()`: `(0..num_chunks)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:2005:22 | 2005 | .zip(degrees.into_iter()) | ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `degrees` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:1556:18 | 1556 | .zip(self.constraints.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `self.constraints` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings`

warning: an array of `Range` that is only one element --> halo2_gadgets/src/utilities.rs:409:47 | 409 | decompose(pallas::Base::random(rng), &[0..255]); | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init = note: `-W clippy::single-range-in-vec-init` implied by `-W clippy::all` help: if you wanted a `Vec` that contains the entire range, try | 409 | decompose(pallas::Base::random(rng), &(0..255).collect::<std::vec::Vec<usize>>()); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ help: if you wanted an array of len 255, try | 409 | decompose(pallas::Base::random(rng), &[0; 255]); | ~~~~~~

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities.rs:126:34 | 126 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities.rs:117:34 | 117 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities.rs:102:34 | 102 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities/lookup_range_check.rs:52:38 | 52 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_gadgets/src/sinsemilla.rs:660:48 | 660 | ... .chain(right.into_iter()), | ^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `right` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_gadgets/src/sinsemilla.rs:659:48 | 659 | ... .chain(left.into_iter()) | ^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `left` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all`

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon.rs:207:33 | 207 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon.rs:160:33 | 160 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives.rs:367:33 | 367 | _domain: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives.rs:260:33 | 260 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives.rs:223:33 | 223 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs:87:38 | 87 | P128Pow5T3Gen(PhantomData::default()) | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_proofs/src/dev.rs:1842:30 | 1842 | ... .fold(Ok(()), |acc, res| acc.and(res)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold((), |acc, res| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `-W clippy::manual-try-fold` implied by `-W clippy::all`

warning: useless conversion to the same type: `I` --> halo2_proofs/src/dev.rs:953:60 | 953 | let mut inputs: Vec<(Vec<_>, usize)> = lookup_input_row_ids | ____________________________________________________________^ 954 | | .clone() 955 | | .into_iter() | |____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into_iter()` | 953 ~ let mut inputs: Vec<(Vec<_>, usize)> = lookup_input_row_ids 954 + .clone() |

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/dev.rs:798:32 | 798 | .chain(blinding_rows.into_iter())) | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `blinding_rows` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `I` --> halo2_proofs/src/dev.rs:795:22 | 795 | (gate_row_ids | ______________________^ 796 | | .clone() 797 | | .into_iter() | |____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into_iter()` | 795 ~ (gate_row_ids 796 + .clone() |

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives/grain.rs:73:32 | 73 | _field: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all`

warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:296:33 | 296 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:253:33 | 253 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:222:33 | 222 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all`

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_gadgets/src/poseidon/pow5.rs:258:58 | 258 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| { | __________________________________________________________^ 259 | | res.and_then(|state| { 260 | | state.full_round( 261 | | &mut region, ... | 266 | | }) 267 | | })?; | |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_gadgets/src/poseidon/pow5.rs:247:61 | 247 | let state = (0..config.half_partial_rounds).fold(Ok(state), |res, r| { | _____________________________________________________________^ 248 | | res.and_then(|state| { 249 | | state.partial_round( 250 | | &mut region, ... | 255 | | }) 256 | | })?; | |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_gadgets/src/poseidon/pow5.rs:243:58 | 243 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| { | __________________________________________________________^ 244 | | res.and_then(|state| state.full_round(&mut region, config, r, r)) 245 | | })?; | |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `-W clippy::manual-try-fold` implied by `-W clippy::all`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:218:22 | 218 | .zip(inv_denoms.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `inv_denoms` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:203:14 | 203 | .zip(assigned_denominators.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `assigned_denominators` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly/ipa/multiopen/prover.rs:117:62 | 117 | let (p_poly, p_poly_blind) = q_polys.into_iter().zip(q_blinds.into_iter()).fold( | ^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `q_blinds` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `std::slice::ChunksMut<'_, bool>` --> halo2_proofs/src/plonk.rs:227:37 | 227 | for (bits, byte) in selector.chunks_mut(8).into_iter().zip(selector_bytes) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `selector.chunks_mut(8)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:376:25 | 376 | / lookups 377 | | .iter() 378 | | .flat_map(move |p| p.queries(vk, x)) 379 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 376 ~ lookups 377 + .iter() 378 ~ .flat_map(move |p| p.queries(vk, x)), |

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:310:25 | 310 | / lookups 311 | | .iter() 312 | | .zip(vk.cs.lookups.iter()) 313 | | .flat_map(move |(p, argument)| { ... | 327 | | }) 328 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 310 ~ lookups 311 + .iter() 312 + .zip(vk.cs.lookups.iter()) 313 + .flat_map(move |(p, argument)| { 314 + p.expressions( 315 + l_0, 316 + l_last, 317 + l_blind, 318 + argument, 319 + theta, 320 + beta, 321 + gamma, 322 + advice_evals, 323 + fixed_evals, 324 + instance_evals, 325 + challenges, 326 + ) 327 ~ }), |

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:679:24 | 679 | .chain(lookups.iter().flat_map(move |p| p.open(pk, x)).into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookups.iter().flat_map(move |p| p.open(pk, x))` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `std::ops::Range<usize>` --> halo2_proofs/src/plonk/vanishing/prover.rs:59:50 | 59 | let mut thread_seeds: Vec<ChaCha20Rng> = (0..num_chunks) | __________________________________________________^ 60 | | .into_iter() | |________________________^ help: consider removing `.into_iter()`: `(0..num_chunks)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities.rs:126:34 | 126 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities.rs:117:34 | 117 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities.rs:102:34 | 102 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/utilities/lookup_range_check.rs:52:38 | 52 | _phantom: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:2005:22 | 2005 | .zip(degrees.into_iter()) | ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `degrees` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:1556:18 | 1556 | .zip(self.constraints.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `self.constraints` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `std::ops::Range<i32>` --> halo2_proofs/src/fft.rs:74:17 | 74 | let a = (0..(1 << max_log_n)) | _________________^ 75 | | .into_iter() | |________________________^ help: consider removing `.into_iter()`: `(0..(1 << max_log_n))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all`

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon.rs:207:33 | 207 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon.rs:160:33 | 160 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives.rs:367:33 | 367 | _domain: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives.rs:260:33 | 260 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives.rs:223:33 | 223 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_gadgets/src/poseidon/primitives/grain.rs:73:32 | 73 | _field: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all`

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_gadgets/src/poseidon/pow5.rs:258:58 | 258 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| { | __________________________________________________________^ 259 | | res.and_then(|state| { 260 | | state.full_round( 261 | | &mut region, ... | 266 | | }) 267 | | })?; | |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_gadgets/src/poseidon/pow5.rs:247:61 | 247 | let state = (0..config.half_partial_rounds).fold(Ok(state), |res, r| { | _____________________________________________________________^ 248 | | res.and_then(|state| { 249 | | state.partial_round( 250 | | &mut region, ... | 255 | | }) 256 | | })?; | |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold

warning: usage of `Iterator::fold` on a type that implements `Try` --> halo2_gadgets/src/poseidon/pow5.rs:243:58 | 243 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| { | __________________________________________________________^ 244 | | res.and_then(|state| state.full_round(&mut region, config, r, r)) 245 | | })?; | |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `-W clippy::manual-try-fold` implied by `-W clippy::all`

warning: useless use of `vec!` --> halo2_proofs/tests/plonk_api.rs:520:25 | 520 | let pubinputs = vec![instance]; | ^^^^^^^^^^^^^^ help: you can use an array directly: `[instance]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `-W clippy::useless-vec` implied by `-W clippy::all`

warning: useless conversion to the same type: `std::ops::Range<usize>` --> halo2_proofs/benches/commit_zk.rs:29:46 | 29 | let mut thread_seeds: Vec<ChaCha20Rng> = (0..n_chunks) | ______________________________________________^ 30 | | .into_iter() | |____________________^ help: consider removing `.into_iter()`: `(0..n_chunks)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all`

warning: useless conversion to the same type: `I` --> halo2_proofs/src/dev.rs:953:60 | 953 | let mut inputs: Vec<(Vec<_>, usize)> = lookup_input_row_ids | ____________________________________________________________^ 954 | | .clone() 955 | | .into_iter() | |____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into_iter()` | 953 ~ let mut inputs: Vec<(Vec<_>, usize)> = lookup_input_row_ids 954 + .clone() |

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/dev.rs:798:32 | 798 | .chain(blinding_rows.into_iter())) | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `blinding_rows` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `I` --> halo2_proofs/src/dev.rs:795:22 | 795 | (gate_row_ids | ______________________^ 796 | | .clone() 797 | | .into_iter() | |____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into_iter()` | 795 ~ (gate_row_ids 796 + .clone() |

warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:296:33 | 296 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:253:33 | 253 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

warning: use of `default` to create a unit struct --> halo2_proofs/src/dev/cost.rs:222:33 | 222 | _marker: PhantomData::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:218:22 | 218 | .zip(inv_denoms.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `inv_denoms` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly.rs:203:14 | 203 | .zip(assigned_denominators.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `assigned_denominators` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/poly/ipa/multiopen/prover.rs:117:62 | 117 | let (p_poly, p_poly_blind) = q_polys.into_iter().zip(q_blinds.into_iter()).fold( | ^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `q_blinds` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `std::slice::ChunksMut<'_, bool>` --> halo2_proofs/src/plonk.rs:227:37 | 227 | for (bits, byte) in selector.chunks_mut(8).into_iter().zip(selector_bytes) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `selector.chunks_mut(8)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:376:25 | 376 | / lookups 377 | | .iter() 378 | | .flat_map(move |p| p.queries(vk, x)) 379 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 376 ~ lookups 377 + .iter() 378 ~ .flat_map(move |p| p.queries(vk, x)), |

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/verifier.rs:310:25 | 310 | / lookups 311 | | .iter() 312 | | .zip(vk.cs.lookups.iter()) 313 | | .flat_map(move |(p, argument)| { ... | 327 | | }) 328 | | .into_iter(), | |________________________________________^ | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing the `.into_iter()` | 310 ~ lookups 311 + .iter() 312 + .zip(vk.cs.lookups.iter()) 313 + .flat_map(move |(p, argument)| { 314 + p.expressions( 315 + l_0, 316 + l_last, 317 + l_blind, 318 + argument, 319 + theta, 320 + beta, 321 + gamma, 322 + advice_evals, 323 + fixed_evals, 324 + instance_evals, 325 + challenges, 326 + ) 327 ~ }), |

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/prover.rs:679:24 | 679 | .chain(lookups.iter().flat_map(move |p| p.open(pk, x)).into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `lookups.iter().flat_map(move |p| p.open(pk, x))` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:523:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `std::ops::Range<usize>` --> halo2_proofs/src/plonk/vanishing/prover.rs:59:50 | 59 | let mut thread_seeds: Vec<ChaCha20Rng> = (0..num_chunks) | __________________________________________________^ 60 | | .into_iter() | |________________________^ help: consider removing `.into_iter()`: `(0..num_chunks)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:2005:22 | 2005 | .zip(degrees.into_iter()) | ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `degrees` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> halo2_proofs/src/plonk/circuit.rs:1556:18 | 1556 | .zip(self.constraints.into_iter()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `self.constraints` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/cc66ad468955717ab92600c770da8c1601a4ff33/library/core/src/iter/traits/iterator.rs:642:12 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-W clippy::useless-conversion` implied by `-W clippy::all`

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/