Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(2892): consider entity resolvers in n + 1 check #2978

Merged
merged 27 commits into from
Nov 28, 2024
Merged

Conversation

meskill
Copy link
Contributor

@meskill meskill commented Oct 8, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #2892, #3008, #3161
/claim #2892

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.77%. Comparing base (263d684) to head (bceaa40).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2978      +/-   ##
==========================================
+ Coverage   86.73%   86.77%   +0.04%     
==========================================
  Files         276      276              
  Lines       27493    27543      +50     
==========================================
+ Hits        23845    23901      +56     
+ Misses       3648     3642       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 14, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 14, 2024
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 28, 2024
@meskill meskill removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 29, 2024
Copy link

github-actions bot commented Nov 3, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Nov 3, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Nov 16, 2024
tusharmath
tusharmath previously approved these changes Nov 17, 2024
@tusharmath tusharmath marked this pull request as draft November 20, 2024 19:37
@meskill meskill marked this pull request as ready for review November 26, 2024 10:38
@meskill meskill requested a review from karatakis November 26, 2024 11:22
@meskill meskill enabled auto-merge (squash) November 28, 2024 10:56
@meskill meskill merged commit ceefed9 into main Nov 28, 2024
33 checks passed
@meskill meskill deleted the fix/npo-entity branch November 28, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle entity resolvers in the n+1 checker
4 participants