Skip to content

Conversation

@MedHeikelBouzayene
Copy link
Contributor

@MedHeikelBouzayene MedHeikelBouzayene commented Oct 9, 2024

Summary:
Resolved an issue where the @modify directive was not functioning correctly with the field's @graphql directive. The query sent by Tailcall to the original GraphQL server was incorrect.

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Oct 9, 2024
@MedHeikelBouzayene MedHeikelBouzayene marked this pull request as ready for review October 9, 2024 12:35
@MedHeikelBouzayene MedHeikelBouzayene marked this pull request as draft October 9, 2024 12:52
@codecov
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.69%. Comparing base (1679aea) to head (81ee4e6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2983   +/-   ##
=======================================
  Coverage   87.68%   87.69%           
=======================================
  Files         276      276           
  Lines       27414    27432   +18     
=======================================
+ Hits        24038    24056   +18     
  Misses       3376     3376           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MedHeikelBouzayene MedHeikelBouzayene marked this pull request as ready for review October 9, 2024 16:17
@MedHeikelBouzayene MedHeikelBouzayene marked this pull request as draft October 9, 2024 16:22
@MedHeikelBouzayene MedHeikelBouzayene marked this pull request as ready for review October 10, 2024 00:19
@MedHeikelBouzayene MedHeikelBouzayene marked this pull request as draft October 10, 2024 08:20
@MedHeikelBouzayene MedHeikelBouzayene marked this pull request as draft October 10, 2024 08:20
@MedHeikelBouzayene MedHeikelBouzayene marked this pull request as ready for review October 10, 2024 13:59
@amitksingh1490
Copy link
Collaborator

@MedHeikelBouzayene You need to push the generated snapshots also.
steps

  1. cargo insta test
  2. cargo insta review
  3. verify the snapshots and commit them to github

@MedHeikelBouzayene
Copy link
Contributor Author

I did add the snapshots, could you approve workflows please.

@amitksingh1490 amitksingh1490 enabled auto-merge (squash) October 12, 2024 19:53
@amitksingh1490 amitksingh1490 merged commit 9b003f8 into tailcallhq:main Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix Iterations on existing features or infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants