-
Notifications
You must be signed in to change notification settings - Fork 258
fix(modify): bug in modify for graphql #2983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
amitksingh1490
merged 14 commits into
tailcallhq:main
from
MedHeikelBouzayene:fix/modify_for_graphql
Oct 12, 2024
Merged
fix(modify): bug in modify for graphql #2983
amitksingh1490
merged 14 commits into
tailcallhq:main
from
MedHeikelBouzayene:fix/modify_for_graphql
Oct 12, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2983 +/- ##
=======================================
Coverage 87.68% 87.69%
=======================================
Files 276 276
Lines 27414 27432 +18
=======================================
+ Hits 24038 24056 +18
Misses 3376 3376 ☔ View full report in Codecov by Sentry. |
Collaborator
|
@MedHeikelBouzayene You need to push the generated snapshots also.
|
Contributor
Author
|
I did add the snapshots, could you approve workflows please. |
amitksingh1490
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Resolved an issue where the
@modifydirective was not functioning correctly with the field's@graphqldirective. The query sent by Tailcall to the original GraphQL server was incorrect.Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>