-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ControlURL #22
Add ControlURL #22
Conversation
Signed-off-by: Leon Lenzen <ich@leonlenzen.de>
Signed-off-by: Leon Lenzen <ich@leonlenzen.de>
I have not found any documentation for config options for network listeners, hence the hijacking of the address field. If there are any better config options for network listeners, feel free to point them out and I will update this PR accordingly. |
I definitely want to pivot to using caddy configuration for any future options like this. I kinda wish I had done it for auth keys as well, but that's already done. I think adding config options for a network listener should work the same as any other caddy directive? I haven't looked closely myself, but it tends to all be pretty consistent. I don't mind doing the initial change to establish the config, which will make future additions like this much simpler. I just probably won't be able to get to it until later in the week |
Sounds good. From my understanding there are no config options for simple listeners/networks. Simple means if you register with I agree having proper config support is beneficial. I will wait with further implementation for your general direction where you want to go with config options. If the general structure is established the authkey could also be integrated but still overridden from env var for backwards compatibility. |
Closes #22 Co-authored-by: ChibangLW <ich@leonlenzen.de> Signed-off-by: Will Norris <will@tailscale.com>
Closes #22 Co-authored-by: ChibangLW <ich@leonlenzen.de> Signed-off-by: Will Norris <will@tailscale.com>
Closes #22 Co-authored-by: ChibangLW <ich@leonlenzen.de> Signed-off-by: Will Norris <will@tailscale.com>
Closes #22 Co-authored-by: ChibangLW <ich@leonlenzen.de> Signed-off-by: Will Norris <will@tailscale.com>
Closes #22 Co-authored-by: ChibangLW <ich@leonlenzen.de> Signed-off-by: Will Norris <will@tailscale.com>
Closes #22 Co-authored-by: ChibangLW <ich@leonlenzen.de> Signed-off-by: Will Norris <will@tailscale.com>
also return any replacer errors, and remove app nil check since we always check prior to calling these config funcs. Closes #22 Co-authored-by: ChibangLW <ich@leonlenzen.de> Signed-off-by: Will Norris <will@tailscale.com>
also return any replacer errors, and remove app nil check since we always check prior to calling these config funcs. Closes #22 Co-authored-by: ChibangLW <ich@leonlenzen.de> Signed-off-by: Will Norris <will@tailscale.com>
also return any replacer errors, and remove app nil check since we always check prior to calling these config funcs. Closes #22 Co-authored-by: ChibangLW <ich@leonlenzen.de> Signed-off-by: Will Norris <will@tailscale.com>
This PR adds the functionality to select the controlURL via env variable.
The small addition was driven by the desire to use caddy-tailscale with headscale.
EDIT:
Just saw #18 and will try to apply the mentioned config option to this PR.