set directive order for tailscale_auth #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irbekrm
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Looks good!
Added an optional nit, also the examples still use the order directive
https://github.com/tailscale/caddy-tailscale/blob/main/examples/auth.caddyfile#L8
https://github.com/tailscale/caddy-tailscale/blob/main/examples/proxyauth.caddyfile#L12
oh, good catch. I really love how simple these example files are getting as we remove more unnecessary config! |
Now that we require Caddy 2.8, we can use the new RegisterDirectiveOrder func to specify the ordering of the `tailscale_auth` directive, rather than instructing users to set it manually. Signed-off-by: Will Norris <will@tailscale.com>
willnorris
force-pushed
the
will/directive-order
branch
from
f0d8130
to
5401ae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we require Caddy 2.8, we can use the new RegisterDirectiveOrder func to specify the ordering of the
tailscale_authdirective, rather than instructing users to set it manually.