libtailscale: fix regression in interface address enumeration #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression in interface address enumeration that was introduced in commit 9c933a0. The change updates the address parsing logic to use the more modern netip.ParsePrefix instead of net.ParseCIDR and converts the parsed prefix to a *net.IPAddr for proper storage in the AltAddrs field.
- Replaces
net.ParseCIDRwithnetip.ParsePrefixfor parsing network addresses - Updates the address storage format from
*net.IPNetto*net.IPAddr - Preserves zone information when converting parsed addresses
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
raggi
force-pushed
the
raggi/interfaceaddrs
branch
from
be6a0d7 to
6956bb3
Compare
Fix regression introduced in 9c933a0. Fixes tailscale/tailscale#16836 Signed-off-by: James Tucker <james@tailscale.com>
raggi
force-pushed
the
raggi/interfaceaddrs
branch
from
6956bb3 to
1b5e15a
Compare
sfllaw
approved these changes
Sep 26, 2025
Comment on lines
+105
to
+112
| var ip net.IP | ||
| if pfx.Addr().Is4() { | ||
| v4 := pfx.Addr().As4() | ||
| ip = net.IP(v4[:]) | ||
| } else { | ||
| v6 := pfx.Addr().As16() | ||
| ip = net.IP(v6[:]) | ||
| } |
There was a problem hiding this comment.
Suggestion (non-blocking): Is this a good place to use netip.Addr.AsSlice?
Suggested change
| var ip net.IP | |
| if pfx.Addr().Is4() { | |
| v4 := pfx.Addr().As4() | |
| ip = net.IP(v4[:]) | |
| } else { | |
| v6 := pfx.Addr().As16() | |
| ip = net.IP(v6[:]) | |
| } | |
| ip := net.IP(pfx.Addr().AsSlice()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression introduced in 9c933a0.
Fixes tailscale/tailscale#16836