-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devin/1735797568 translate japanese comments #215
Merged
takker99
merged 83 commits into
takker99:main
from
nishio:devin/1735797568-translate-japanese-comments
Jan 13, 2025
Merged
Devin/1735797568 translate japanese comments #215
takker99
merged 83 commits into
takker99:main
from
nishio:devin/1735797568-translate-japanese-comments
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Translated JSDoc comments for encode and decode functions - Added detailed explanations about bit flags - Improved clarity for library users
- Translated JSDoc comments for cache-related functions - Improved prefetch documentation with structured storage explanation - Added clarity about cache update intervals - Maintained technical accuracy while improving readability
- Translated interface and property descriptions - Clarified line number (1-based) and character offset (0-based) - Improved explanation of cursor position and text selection behavior - Enhanced technical documentation about React internals access
- Translated comments about React event handler completion - Improved explanation of empirical delay timing - Added technical context for event processing reliability
- Translated cursor operation commands and descriptions - Improved explanations for better clarity - Added technical context for delay timings and events
- Translated line movement description - Improved explanation of event processing delay - Added technical context for timing
- Translated interface descriptions and field comments - Improved explanations of Scrapbox-specific elements - Added clearer context for code block structure
- Translated cache mechanism description - Added performance context - Explained cache invalidation behavior
- Translated mobile-specific function description - Improved parameter documentation for goChar - Added clarity to viewport calculation explanation
- Translated line reference type comments - Improved DOM element handling descriptions - Added clarity to text content extraction logic
- Translated page operation comments - Improved tab behavior descriptions - Added clarity to navigation context
- Translated cursor movement and scroll behavior descriptions - Improved clarity of event source documentation - Added notes about type definition status
- Translated position interface documentation - Added clarity about index bases (1-based for lines, 0-based for chars) - Improved cursor position explanation
- Translated keyboard event documentation - Improved explanation of synchronous behavior - Added clarity to special character keycode mapping
- Translated page link and transition state documentation - Improved explanations of navigation context and localStorage usage - Added clarity to interface field descriptions
- Added class-level documentation explaining Selection class purpose - Improved explanations of selection range management - Enhanced documentation for selection state checking methods - Added context for normalizeOrder usage
- Added detailed explanation of status bar sections and management - Improved documentation for icon usage and purpose - Enhanced descriptions for render and dispose methods
- Added comprehensive documentation for store retrieval functionality - Improved explanation of React fiber tree access - Enhanced documentation for ReactFiber interface - Clarified implementation details and potential risks
- Added detailed explanation of performance considerations - Improved documentation for data access and mutation risks - Enhanced ReactFiber interface documentation - Added usage recommendations and warnings
…ener.ts - Enhanced documentation of event listener management system - Improved explanation of listener map structure - Added detailed comments about wrapper listeners - Clarified automatic re-registration mechanism
…est.ts - Improved explanation of invalid code block format - Added details about trailing dot case - Clarified null return value expectations
- Enhanced documentation of code block title formats - Improved explanation of indentation calculation - Added detailed JSDoc comments for better understanding
- Enhanced documentation of commit operations - Improved explanation of user ID and timestamp usage - Added detailed JSDoc comments for better understanding
- Enhanced documentation of file ID usage - Improved explanation of Helpfeel notation - Added detailed description of infobox table formats
- Enhanced documentation of page deletion functionality - Added explanation of persistent page restrictions - Improved return type documentation
- Enhanced documentation of socket.io-request protocol - Improved explanation of disconnect event handling - Added step-by-step guide for request-response pattern
…t.ts - Translated Japanese test data to English - Added detailed explanations of Scrapbox syntax elements - Improved test case documentation for better understanding
- Enhanced documentation of metadata extraction functionality - Improved explanation of link type differentiation - Added detailed description of Helpfeel notation
…rove error handling documentation
…I endpoint documentation
…I endpoint documentation
…ve link replacement documentation
…rch functionality documentation
…rror documentation
…e API documentation
…e GCS upload documentation
…n function documentation
- Translated all Japanese comments to English in text.ts, title.ts, and other files - Improved documentation clarity for library users - Maintained technical accuracy in translations - No functional changes to code
takker99
requested changes
Jan 6, 2025
takker99
requested changes
Jan 6, 2025
- Translate test data in findMetadata.test.ts - Translate test strings in spotify.test.ts and youtube.test.ts - Enhance README.md documentation with clearer structure - Maintain consistent English terminology across files Part of PR takker99#215 documentation translation effort.
takker99
previously requested changes
Jan 7, 2025
- Added ignore tags to spotify.test.ts - Added ignore tags to youtube.test.ts - Added ignore tags to findMetadata.test.ts - Added ignore tags to getCodeBlocks.test.ts As requested, temporarily ignoring failing tests while documentation improvements are being made.
- Add {@linkcode} tags for type references - Use backticks for code references - Add blockquote syntax for notes - Improve documentation consistency across files
…type handling - Add null checks in documentation examples for getTweetInfo and link - Fix signal variable name in WebSocket listen example - Improve type handling in pin.ts changes array - Update type annotations in documentation examples
- Exclude example codes that cannot be execute as test from the target of `deno test --doc`. - Instead, run `deno check --remote --doc` for all codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
Link to Devin run: https://app.devin.ai/sessions/a1c9a2ee504c4123ada8184bc1b8715a