Skip to content

Commit

Permalink
use network='bridge', ipc='private' as defaults for docker
Browse files Browse the repository at this point in the history
There was an issue around virtual X window manager that somehow expects
a unique instance within the same network (?). And it complained when
launching multiple containers at the same time
  • Loading branch information
takuma-yoneda committed Aug 24, 2023
1 parent aefe080 commit b0c5294
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lmn/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from lmn import logger

class DockerContainerConfig:
def __init__(self, image, name, env: dict | None = None, remove=True, network='host', ipc_mode='host', mounts=None,
def __init__(self, image, name, env: dict | None = None, remove=True, network='bridge', ipc_mode='private', mounts=None,
startup: str | None = None, tty=True, use_gpus=True, user_id: int = 0, group_id: int = 0, runtime='docker') -> None:
"""
user_id (int | str): The format is either 2003 for user_id or 2003:4000 to specify user id and group id.
Expand Down

0 comments on commit b0c5294

Please sign in to comment.