Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State bug fix #17

Merged
merged 8 commits into from
Dec 14, 2023
Merged

State bug fix #17

merged 8 commits into from
Dec 14, 2023

Conversation

tan12082001
Copy link
Owner

Final Capstone Review - One - Changes

  • Removed commented code lines.
  • Updated the sign-in bug that is taking two clicks to sign in, now the sign-in redirects on one click if the sign-in action is fulfilled.
  • Updated the delete-car-related components to have the dispatch action of fetchCars so that when an item is deleted there will be a new fetch that removes the deleted item.
  • Updated the reservations-related component with fetchCarReservations dispatch action that would render respective names and all the reservations.
  • updated the backend controller to fix the undefined id null call error.

@Simpleshaikh1 Simpleshaikh1 self-requested a review December 14, 2023 10:12
Simpleshaikh1
Simpleshaikh1 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@Simpleshaikh1 Simpleshaikh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to merge

@tan12082001 tan12082001 merged commit 2b8fc77 into dev Dec 14, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simpleshaikh1 Simpleshaikh1 Simpleshaikh1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tan12082001 @Simpleshaikh1