Login signup Form components #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simpleshaikh1
requested changes
Dec 6, 2023
src/pages/Auth/SignUp/SignupForm.js
Outdated
Comment on lines
27
to
28
| <TextInputField label="Password" name="password" placeholder="eg. A1@_3er" /> | ||
| <TextInputField label="Confirm Password" name="confirm_password" /> |
There was a problem hiding this comment.
Great implementation so far, I want to suggest if you can use the HideableTextFormField for the Password input, instead of of TextInputField component to add the visibility to the password.
src/pages/Auth/SignIn/SigninForm.js
Outdated
| className="sign-in-form" | ||
| > | ||
| <TextInputField label="Email" name="email" placeholder="eg. example@example.com" /> | ||
| <TextInputField label="Password" name="password" placeholder="eg. A1@_3er" /> |
There was a problem hiding this comment.
Great work so far, I want to suggest using the HideableTextFormField in the password input , instead of the TextInputField component to add the visiblilty for password.
Simpleshaikh1
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Login and SignUp page forms:
Implemented tasks:
authenticationSlicefor adding reducers.Need to implement:
Current login and signup forms: