Add new car #9
Merged
Add new car #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tan12082001
requested changes
Dec 10, 2023
Comment on lines
18
to
32
| <FormComponent | ||
| initialValues={carInitialValues} | ||
| schema={CarSchema} | ||
| onSubmit={handleSubmit} | ||
| className="" | ||
| > | ||
| <TextInputField label="Car Name" name="name" placeholder="Car Name" /> | ||
| <TextAreaInputField label="Description" name="description" placeholder="Description" /> | ||
| <TextInputField label="Price/hr" name="pricePrHr" placeholder="Price"/> | ||
| <TextInputField label="Sitting Capacity" name="sitting_capacity" placeholder="Sitting Capacity" /> | ||
| <TextInputField label="Rental Duration" name="rental_duration" placeholder="Duration" /> | ||
| <FormSubmitButton type="submit" className="sign-up-submit"> | ||
| Create | ||
| </FormSubmitButton> | ||
| </FormComponent> |
There was a problem hiding this comment.
The form looks good! But can you also add another form text field for image input so that a user can provide the link for the car they are going to create? Update the CarSchema accordingly. 👍
tan12082001
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a form to add new car.