Remove deprecated classic theme files

[richardissuperman]

1. Remove cd build/ as python files are with the same dir
2. use absolute path so the script can work wherever dev run sh command

[richardissuperman]

TODO: update the README.md's animation gif

[tancheng]

We may need ../ as the mode_dark_light.py invokes many sh commands with fixed relative path, e.g., mkdir os.system("mkdir test") or sh ../tools/sth, which assumes every generated file is kept inside a build folder. This is not good, but it is the current status, plz feel free to clean them up.

@yuqisun Plz confirm my statement. Thanks.

[yuqisun]

Yes, you can find many os.chdir with relative path.

[richardissuperman]

@yuqisun @tancheng interesting, so in my docker container i dont even see this build/ directory. Is there any missing steps i didnt perform to make the build/ folder and artifacts?

I was confused why there was a cd build/ in the scripts? We can discuss on monday meeting.

[yuqisun]

hi @richardissuperman , looks the build folder is missed in image. There should be error when start from python launch.py if there's build folder right?

[richardissuperman]

@yuqisun yes thats why I always just change this locally. I was thinking if you guys run any additional commands to generate build folder.

[tancheng]

@yuqisun yes thats why I always just change this locally. I was thinking if you guys run any additional commands to generate build folder.

We can add the command of creating build if it doesn't exit?

[tancheng]

BTW, can you help create a doc directory and move both theme and debug into it?

[richardissuperman]

BTW, can you help create a doc directory and move both theme and debug into it?

@tancheng
sure happy to do that! few questions:

1. Shall we also move my mac debugging tips into doc dir as well?
2. Pictures under theme are also referenced as part of the source code inside launch.python, do we still want to move it under doc? I thought theme/ is part of the assets used by code not document (No.2 doesnt really matter that much though, just asking)

[tancheng]

Hi @richardissuperman, let's move all of them into the /doc. And change the path in the code accordingly. The docker dbugging anyway can be directed to the location from the root README. Thanks~!

[richardissuperman]

I accidentally close this by force push my master branch, but this is fine, lets address #60 first and later after discuss comment# i can reopen this PR.