Use relative path to generate kernel folder #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
richardissuperman
commented
Jul 26, 2025
richardissuperman
commented
tancheng
reviewed
Jul 26, 2025
mode_dark_light.py
Outdated
| os.chdir("kernel") | ||
| script_dir = os.path.dirname(os.path.abspath(__file__)) | ||
|
|
||
| kernel_dir = os.path.join(script_dir, "kernel") |
Owner
There was a problem hiding this comment.
IIRC, this kernel folder should be created within the build folder, right? You are now creating it inside the repo/ where the launch_script.py stays?
Collaborator
Author
There was a problem hiding this comment.
oh ok! let me revise.
the core problem of current code is that it uses the current path which triggers the script, so not stable enough.
Otherwise kernel will be made in the place where you run the command
instead of relative lower layer of the script folder
richardissuperman
force-pushed
the
master
branch
from
e6b0f96 to
fc36f75
Compare
Collaborator
Author
|
@yuqisun change to use build/kernel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.