Add position information support #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add includeDetails parameter to main export function - Return position metadata when requested - Add tests and documentation Add position information support - Add includeDetails parameter to main export function - Return position metadata when requested - Add tests and documentation
| }; | ||
|
|
||
| module.exports = (str) => { | ||
| module.exports = (str, includeDetails = false) => { |
There was a problem hiding this comment.
I can't imagine anyone is using a node version old enough for this to matter, but we should nonetheless update the engines key in package.json for node 6.0.0, since that is when default parameters became standard.
There was a problem hiding this comment.
I guess it should have actually already been that, since I was using const and let, so you can help me out by fixing my mistake
| } | ||
|
|
||
| if (!includeDetails) { | ||
| return objects.map(item => item.object); |
There was a problem hiding this comment.
I like to always put parens around function parameters, even when not required as in this case.
Suggested change
| return objects.map(item => item.object); | |
| return objects.map((item) => item.object); |
tandrewnichols
requested changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.