Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Black formatting action #734

Merged
merged 4 commits into from
Dec 26, 2024
Merged

Add Black formatting action #734

merged 4 commits into from
Dec 26, 2024

Conversation

Adamtaranto
Copy link
Collaborator

@Adamtaranto Adamtaranto commented Dec 25, 2024 •
edited
Loading

Format all .py files in './jcvi' and './tests' with Ruff Black upon commit to a PR.

Closes #721

@Adamtaranto Adamtaranto changed the title WIP: Add Ruff formatting action Add Ruff formatting action Dec 25, 2024
@Adamtaranto Adamtaranto added the github action Add or change behaviour of a github action label Dec 25, 2024
@Adamtaranto Adamtaranto self-assigned this Dec 25, 2024
tanghaibao
tanghaibao reviewed Dec 25, 2024
View reviewed changes
Copy link
Owner

@tanghaibao tanghaibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Adamtaranto

Current codebase is already formatted with black. Is there a way that you can set the ruff style to match black. I really don't want to change my tooling. Thanks.

@Adamtaranto Adamtaranto changed the title Add Ruff formatting action Add Black formatting action Dec 26, 2024
@Adamtaranto
Copy link
Collaborator Author

@tanghaibao Changed to use Black instead. You can add any custom configs to pyproject.toml

tanghaibao
tanghaibao approved these changes Dec 26, 2024
View reviewed changes
Copy link
Owner

@tanghaibao tanghaibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This is great!

@tanghaibao tanghaibao merged commit 756adc1 into main Dec 26, 2024
@tanghaibao tanghaibao deleted the ruff_format_action branch December 26, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanghaibao tanghaibao tanghaibao approved these changes

Assignees

@Adamtaranto Adamtaranto

Labels
github action Add or change behaviour of a github action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add formatting action
2 participants
@Adamtaranto @tanghaibao