This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Generate simpler code for Int and Long division and remainder. #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
force-pushed
the
simpler-int-div-mod
branch
from
11d0eb9
to
d045f60
Compare
Notably, when the rhs is a constant, we can emit straightforward code without any branches. This is worth it because the divisor of integer divisions and remainders is often constant in practice. To handle the overflow case of `MinValue / -1`, we also remove one branch by turning `lhs / -1` into `0 - lhs`. The previous codegen used `if (lhs == MinValue) MinValue else lhs / -1` in the same situation.
sjrd
force-pushed
the
simpler-int-div-mod
branch
from
d045f60
to
db34150
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably, when the rhs is a constant, we can emit straightforward code without any branches. This is worth it because the divisor of integer divisions and remainders is often constant in practice.
To handle the overflow case of
MinValue / -1, we also remove one branch by turninglhs / -1into0 - lhs. The previous codegen usedif (lhs == MinValue) MinValue else lhs / -1in the same situation.