This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Local cleanups in ClassEmitter. #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything else that generates code is called `genX` at this point.
It has been a no-op for a while.
Which we rename to genScalaClass.
That centralizes building of all the `StructField`s of a class' struct type.
Since one was the only caller of the other.
This corresponds to how it is called in the JS backend.
By spec, the constructor to call for a module class is always `<init>()`, i.e., `NoArgConstructorName`.
It was its only call site, and separating it does not help.
sjrd
force-pushed
the
cleanup-classemitter
branch
from
6ec2008
to
ce367d1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.