Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix new clang -Wdeprecated-literal-operator (no whitespace between ""… #159

Conversation

SvenJo
Copy link
Contributor

@SvenJo SvenJo commented Mar 9, 2025

New Clang 20 compiler warning: -Wdeprecated-literal-operator

Generate warning (and with -Werror errors) like:

/home/sven/src/json/include/tao/json/binary.hpp:94:57: error: identifier '_binary' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator]
   94 |       [[nodiscard]] std::vector< std::byte > operator"" _binary()
      |                                              ~~~~~~~~~~~^~~~~~~
      |                                              operator""_binary

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

Attention: Patch coverage is 92.92035% with 8 lines in your changes missing coverage. Please review.

Project coverage is 73.98%. Comparing base (3d1d4fc) to head (f6ef3e8).

Files with missing lines Patch % Lines
include/tao/json/pointer.hpp 92.07% 0 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   74.01%   73.98%   -0.04%     
==========================================
  Files         257      257              
  Lines        9191     9187       -4     
  Branches      804      808       +4     
==========================================
- Hits         6803     6797       -6     
  Misses       1785     1785              
- Partials      603      605       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SvenJo
Copy link
Contributor Author

SvenJo commented Mar 9, 2025

Sorry, include format changes.

@SvenJo SvenJo closed this Mar 9, 2025
@SvenJo SvenJo deleted the bugfix/new-clang20-warning--Wdeprecated-literal-operator branch March 9, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant