Cleanup clang-tidy issues

taocpp · Nov 17, 2024 · a8b7bf6 · a8b7bf6
1 parent 115cbda
commit a8b7bf6
Show file tree

Hide file tree

Showing 21 changed files with 91 additions and 3 deletions.
diff --git a/src/lib/pq/internal/poll.cpp b/src/lib/pq/internal/poll.cpp
@@ -8,7 +8,6 @@
 #include <cerrno>
 #include <cstring>
 #include <format>
-#include <string.h>
 #include <string>
 
 #if defined( _WIN32 )

diff --git a/src/lib/pq/large_object.cpp b/src/lib/pq/large_object.cpp
@@ -7,17 +7,20 @@
 #include <cassert>
 #include <cstddef>
 #include <cstdint>
+#include <cstdio>
 #include <ios>
 #include <memory>
 #include <stdexcept>
 #include <string>
 #include <utility>
 
+#include <libpq-fe.h>
 #include <libpq/libpq-fs.h>
 
 #include <tao/pq/binary.hpp>
 #include <tao/pq/connection.hpp>
 #include <tao/pq/internal/resize_uninitialized.hpp>
+#include <tao/pq/oid.hpp>
 #include <tao/pq/transaction.hpp>
 
 namespace tao::pq

diff --git a/src/lib/pq/table_writer.cpp b/src/lib/pq/table_writer.cpp
@@ -7,6 +7,7 @@
 #include <chrono>
 #include <cstddef>
 #include <memory>
+#include <stdexcept>
 #include <string_view>
 #include <tuple>
 

diff --git a/src/lib/pq/transaction.cpp b/src/lib/pq/transaction.cpp
@@ -8,6 +8,7 @@
 #include <cstdio>
 #include <exception>
 #include <memory>
+#include <stdexcept>
 #include <utility>
 
 #include <libpq-fe.h>

diff --git a/src/test/pq/aggregate.cpp b/src/test/pq/aggregate.cpp
@@ -5,6 +5,10 @@
 #include "../getenv.hpp"
 #include "../macros.hpp"
 
+#include <exception>
+#include <iostream>
+#include <string>
+
 #include <tao/pq.hpp>
 
 namespace example

diff --git a/src/test/pq/array.cpp b/src/test/pq/array.cpp
@@ -5,6 +5,13 @@
 #include "../getenv.hpp"
 #include "../macros.hpp"
 
+#include <array>
+#include <exception>
+#include <iostream>
+#include <optional>
+#include <string>
+#include <vector>
+
 #include <tao/pq.hpp>
 
 namespace

diff --git a/src/test/pq/connection.cpp b/src/test/pq/connection.cpp
@@ -5,9 +5,16 @@
 #include "../getenv.hpp"
 #include "../macros.hpp"
 
+#include <chrono>
+#include <exception>
+#include <iostream>
+#include <string>
 #include <tuple>
 
+#include <tao/pq/binary.hpp>
 #include <tao/pq/connection.hpp>
+#include <tao/pq/internal/unreachable.hpp>
+#include <tao/pq/poll.hpp>
 
 namespace
 {

diff --git a/src/test/pq/connection_pool.cpp b/src/test/pq/connection_pool.cpp
@@ -5,7 +5,17 @@
 #include "../getenv.hpp"
 #include "../macros.hpp"
 
+#include <atomic>
+#include <chrono>
+#include <cstddef>
+#include <exception>
+#include <iostream>
+#include <memory>
+#include <stdexcept>
+
 #include <tao/pq/connection_pool.hpp>
+#include <tao/pq/internal/unreachable.hpp>
+#include <tao/pq/poll.hpp>
 
 namespace
 {

diff --git a/src/test/pq/example.cpp b/src/test/pq/example.cpp
@@ -5,7 +5,10 @@
 #include "../getenv.hpp"
 #include "../macros.hpp"
 
+#include <exception>
 #include <iostream>
+#include <string>
+
 #include <tao/pq.hpp>
 
 namespace

diff --git a/src/test/pq/getenv.cpp b/src/test/pq/getenv.cpp
@@ -5,6 +5,9 @@
 #include "../getenv.hpp"
 #include "../macros.hpp"
 
+#include <exception>
+#include <iostream>
+
 namespace
 {
    void run()

diff --git a/src/test/pq/large_object.cpp b/src/test/pq/large_object.cpp
@@ -6,7 +6,13 @@
 #include "../getenv.hpp"
 #include "../macros.hpp"
 
+#include <exception>
+#include <ios>
+#include <iostream>
 #include <limits>
+#include <memory>
+#include <string_view>
+#include <utility>
 
 #include <tao/pq/binary.hpp>
 #include <tao/pq/connection.hpp>

diff --git a/src/test/pq/notifications.cpp b/src/test/pq/notifications.cpp
@@ -5,6 +5,10 @@
 #include "../getenv.hpp"
 #include "../macros.hpp"
 
+#include <cstddef>
+#include <exception>
+#include <iostream>
+
 #include <tao/pq/connection.hpp>
 
 #if defined( _WIN32 )

diff --git a/src/test/pq/parameter.cpp b/src/test/pq/parameter.cpp
@@ -5,7 +5,10 @@
 #include "../getenv.hpp"
 #include "../macros.hpp"
 
+#include <exception>
 #include <iostream>
+#include <utility>
+
 #include <tao/pq.hpp>
 
 namespace

diff --git a/src/test/pq/resize_uninitialized.cpp b/src/test/pq/resize_uninitialized.cpp
@@ -4,6 +4,12 @@
 
 #include "../macros.hpp"
 
+#include <cstddef>
+#include <exception>
+#include <iostream>
+#include <string>
+#include <vector>
+
 #include <tao/pq/internal/resize_uninitialized.hpp>
 
 namespace

diff --git a/src/test/pq/result.cpp b/src/test/pq/result.cpp
@@ -5,6 +5,13 @@
 #include "../getenv.hpp"
 #include "../macros.hpp"
 
+#include <exception>
+#include <iostream>
+#include <optional>
+#include <string>
+#include <tuple>
+#include <utility>
+
 #include <tao/pq/connection.hpp>
 #include <tao/pq/result_traits_optional.hpp>
 #include <tao/pq/result_traits_pair.hpp>

diff --git a/src/test/pq/row.cpp b/src/test/pq/row.cpp
@@ -5,6 +5,12 @@
 #include "../getenv.hpp"
 #include "../macros.hpp"
 
+#include <exception>
+#include <iostream>
+#include <optional>
+#include <tuple>
+#include <utility>
+
 #include <tao/pq/connection.hpp>
 #include <tao/pq/result_traits_optional.hpp>
 #include <tao/pq/result_traits_pair.hpp>

diff --git a/src/test/pq/strtox.cpp b/src/test/pq/strtox.cpp
@@ -9,10 +9,11 @@ auto main() -> int {}
 #include "../macros.hpp"
 
 #include <cmath>
+#include <exception>
 #include <format>
+#include <iostream>
 #include <stdexcept>
 #include <tuple>
-#include <typeinfo>
 
 #include <tao/pq/internal/strtox.hpp>
 

diff --git a/src/test/pq/table_reader.cpp b/src/test/pq/table_reader.cpp
@@ -6,6 +6,12 @@
 #include "../getenv.hpp"
 #include "../macros.hpp"
 
+#include <cstddef>
+#include <exception>
+#include <iostream>
+#include <optional>
+#include <string_view>
+
 #include <tao/pq.hpp>
 
 namespace

diff --git a/src/test/pq/table_writer.cpp b/src/test/pq/table_writer.cpp
@@ -5,7 +5,8 @@
 #include <cstddef>
 #include <exception>
 #include <iostream>
-#include <memory>
+#include <optional>
+#include <tuple>
 
 #include "../getenv.hpp"
 #include "../macros.hpp"

diff --git a/src/test/pq/traits.cpp b/src/test/pq/traits.cpp
@@ -5,6 +5,11 @@
 #include "../getenv.hpp"
 #include "../macros.hpp"
 
+#include <exception>
+#include <iostream>
+#include <tuple>
+#include <utility>
+
 #include <tao/pq.hpp>
 
 namespace example

diff --git a/src/test/pq/transaction.cpp b/src/test/pq/transaction.cpp
@@ -5,9 +5,14 @@
 #include "../getenv.hpp"
 #include "../macros.hpp"
 
+#include <exception>
+#include <iostream>
+#include <memory>
 #include <tuple>
 
+#include <tao/pq/access_mode.hpp>
 #include <tao/pq/connection.hpp>
+#include <tao/pq/isolation_level.hpp>
 
 namespace
 {