Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up imports and fix tests for CI #269

Merged
merged 22 commits into from
Aug 1, 2024
Merged

Clean up imports and fix tests for CI #269

merged 22 commits into from
Aug 1, 2024

Conversation

sli-tao
Copy link
Contributor

@sli-tao sli-tao commented Jul 7, 2024 •
edited
Loading

Taoshi Pull Request

Description

add linting, run all unit tests

Related Issues (JIRA)

https://sataoshi.atlassian.net/jira/software/c/projects/TE/boards/2?selectedIssue=TE-360

Checklist

  • I have tested my changes on testnet.
  • I have updated any necessary documentation.
  • I have added unit tests for my changes (if applicable).
  • If there are breaking changes for validators, I have (or will) notify the community in Discord of the release.

Reviewer Instructions

[Provide any specific instructions or areas you would like the reviewer to focus on.]

Definition of Done

  • Code has been reviewed.
  • All checks and tests pass.
  • Documentation is up to date.
  • Approved by at least one reviewer.

Checklist (for the reviewer)

  • Code follows project conventions.
  • Code is well-documented.
  • Changes are necessary and align with the project's goals.
  • No breaking changes introduced.

Optional: Deploy Notes

[Any instructions or notes related to deployment, if applicable.]

/cc @mention_reviewer

@sli-tao sli-tao marked this pull request as ready for review July 15, 2024 09:05
@sli-tao sli-tao force-pushed the chore/continuous-integration branch 3 times, most recently from e33800c to ef846c0 Compare July 31, 2024 17:00
@sli-tao sli-tao changed the title implement ci Clean up imports and fix tests for CI Jul 31, 2024
sli-tao and others added 21 commits August 1, 2024 10:02
@sli-tao
ruff linting
3d9994d
@sli-tao
remove unused imports and fstring
12a1855
@sli-tao
ignore existing violations
eddba94
@sli-tao
run unit tests with pytest
adfce4e
@sli-tao
remove pip cache
45816d4
@sli-tao
run with python bin
63dd927
@sli-tao
update auto_sync tests
7d4f9fd
@sli-tao
fix test_position_manager
57cb4e6
@sli-tao
ruff after rebase
4a096cd
@sli-tao
remove unused imports from p2p_syncer
3247e00
@sli-tao
do not raise ValiFileMissingException when running unit tests
94decd4
@sli-tao
mock twelvedata and polygon
061ecba
@sli-tao
fix test_two_positions_no_collisions, no carry fees on weekend
7b41afa
@sli-tao
update test_event_overlap, tracker does not save events with duplicat…
4542415 
…e timestamp
@sli-tao
disable plagiarism test
0ad4512
@sli-tao
update test_crypto_edge_case, current_time before start_time
a2b5733
@sli-tao
add ETHUSD to fetch_prices mock
942c74d
@trdougherty @sli-tao
Update for consistency sigmoid testing function
d985ccb
@sli-tao
remove some test_mdd tests
2935dda
@sli-tao
Fix after rebase
3fbe022
@sli-tao
update assertions for positional leverage v2
99f33d6
@sli-tao sli-tao force-pushed the chore/continuous-integration branch from ef846c0 to cd9a7c3 Compare August 1, 2024 17:07
@sli-tao sli-tao merged commit 71ba9d9 into main Aug 1, 2024
4 checks passed
@sli-tao sli-tao deleted the chore/continuous-integration branch August 1, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbonilla-tao jbonilla-tao jbonilla-tao approved these changes

@trdougherty trdougherty Awaiting requested review from trdougherty trdougherty is a code owner

@taoshidev1 taoshidev1 Awaiting requested review from taoshidev1 taoshidev1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sli-tao @jbonilla-tao @trdougherty