Skip to content

Commit

Permalink
Fix tnt_cartridge_failover_trigger metric name (#396)
Browse files Browse the repository at this point in the history
  • Loading branch information
yngvar-antonsson authored Aug 9, 2022
1 parent 221e4d1 commit 747d14f
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added

- Label `thread` for per thread reporting net statistics metrics.
- `tnt_cartridge_failover_trigger` metric
- `tnt_cartridge_failover_trigger_total` metric
- New synchro and election metrics:
- `tnt_synchro_queue_owner`
- `tnt_synchro_queue_term`
Expand Down
2 changes: 1 addition & 1 deletion doc/monitoring/metrics_reference.rst
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ Cartridge
* ``max`` -- difference with the fastest clock (always positive),
* ``min`` -- difference with the slowest clock (always negative).

* - ``tnt_cartridge_failover_trigger``
* - ``tnt_cartridge_failover_trigger_total``
- Count of failover triggers in cluster.

.. _metrics-reference-luajit:
Expand Down
2 changes: 1 addition & 1 deletion metrics/cartridge/failover.lua
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ local function update()
if trigger_cnt ~= nil then
collectors_list.trigger_cnt =
utils.set_counter(
'cartridge_failover_trigger',
'cartridge_failover_trigger_total',
'Count of Cartridge Failover triggers',
trigger_cnt
)
Expand Down
2 changes: 1 addition & 1 deletion test/integration/cartridge_metrics_test.lua
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ g.test_failover = function()

helpers.retrying({timeout = 30}, function()
local resp = g.cluster:server('replica'):http_request('get', '/metrics')
local failover_trigger_cnt = utils.find_metric('tnt_cartridge_failover_trigger', resp.json)
local failover_trigger_cnt = utils.find_metric('tnt_cartridge_failover_trigger_total', resp.json)
t.assert_equals(failover_trigger_cnt[1].value, 1)
end)

Expand Down

0 comments on commit 747d14f

Please sign in to comment.