Fix inverted date filtering logic in load_gee_as_image()#79
Open
mihiarc wants to merge 1 commit intotaraskiba:mainfrom
Open
Fix inverted date filtering logic in load_gee_as_image()#79mihiarc wants to merge 1 commit intotaraskiba:mainfrom
mihiarc wants to merge 1 commit intotaraskiba:mainfrom
Conversation
The condition for applying date filters was inverted - filters were
being applied when dates were None rather than when they were provided.
Changed from:
if start_date is None and end_date is None:
col = col.filterDate(start_date, end_date)
To:
if start_date is not None and end_date is not None:
col = col.filterDate(start_date, end_date)
Fixes taraskiba#75
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
load_gee_as_image()functionsProblem
The date filtering logic was inverted - filters were being applied when dates were
Nonerather than when they were provided:This caused:
Nonevalues when no dates were providedSolution
Files Changed
skiba/point_extraction.pyskiba/aggregated_point_extraction.pyskiba/buffer_method.pyTesting
The fix is straightforward logic correction. Date filtering now works as expected:
Fixes #75