Refactored os.path to pathlib in CARSUS (#388) #432

Nitish-Naik · 2025-03-06T07:04:19Z

📝 Description

Type: :| 🚀 feature | ☣️ breaking change | 🎢 infrastructure

This PR helps aims to migrate to pathlib instead of using os.path
like tardis.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

Testing pipeline
Other method (describe)
My changes can't be tested (explain why)

☑️ Checklist

I requested two reviewers for this pull request
I updated the documentation according to my changes
I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

github-actions · 2025-03-06T07:04:57Z

*beep* *bop*
Hi human,
I ran ruff on the latest commit (49eb6d1).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

241	F821	[ ] undefined-name
59	F405	[ ] undefined-local-with-import-star-usage
8	E402	[ ] module-import-not-at-top-of-file
5	E741	[ ] ambiguous-variable-name
4	E712	[*] true-false-comparison
2	F403	[ ] undefined-local-with-import-star

Complete output(might be large):

carsus/data/basic_atomic_data.csv:1:1: F821 Undefined name `atomic_number`
carsus/data/basic_atomic_data.csv:1:15: F821 Undefined name `symbol`
carsus/data/basic_atomic_data.csv:1:22: F821 Undefined name `name`
carsus/data/basic_atomic_data.csv:1:27: F821 Undefined name `group`
carsus/data/basic_atomic_data.csv:1:33: F821 Undefined name `period`
carsus/data/basic_atomic_data.csv:2:3: F821 Undefined name `H`
carsus/data/basic_atomic_data.csv:2:5: F821 Undefined name `Hydrogen`
carsus/data/basic_atomic_data.csv:3:3: F821 Undefined name `He`
carsus/data/basic_atomic_data.csv:3:6: F821 Undefined name `Helium`
carsus/data/basic_atomic_data.csv:4:3: F821 Undefined name `Li`
carsus/data/basic_atomic_data.csv:4:6: F821 Undefined name `Lithium`
carsus/data/basic_atomic_data.csv:5:3: F821 Undefined name `Be`
carsus/data/basic_atomic_data.csv:5:6: F821 Undefined name `Beryllium`
carsus/data/basic_atomic_data.csv:6:3: F821 Undefined name `B`
carsus/data/basic_atomic_data.csv:6:5: F821 Undefined name `Boron`
carsus/data/basic_atomic_data.csv:7:3: F821 Undefined name `C`
carsus/data/basic_atomic_data.csv:7:5: F821 Undefined name `Carbon`
carsus/data/basic_atomic_data.csv:8:3: F821 Undefined name `N`
carsus/data/basic_atomic_data.csv:8:5: F821 Undefined name `Nitrogen`
carsus/data/basic_atomic_data.csv:9:3: F821 Undefined name `O`
carsus/data/basic_atomic_data.csv:9:5: F821 Undefined name `Oxygen`
carsus/data/basic_atomic_data.csv:10:3: F821 Undefined name `F`
carsus/data/basic_atomic_data.csv:10:5: F821 Undefined name `Fluorine`
carsus/data/basic_atomic_data.csv:11:4: F821 Undefined name `Ne`
carsus/data/basic_atomic_data.csv:11:7: F821 Undefined name `Neon`
carsus/data/basic_atomic_data.csv:12:4: F821 Undefined name `Na`
carsus/data/basic_atomic_data.csv:12:7: F821 Undefined name `Sodium`
carsus/data/basic_atomic_data.csv:13:4: F821 Undefined name `Mg`
carsus/data/basic_atomic_data.csv:13:7: F821 Undefined name `Magnesium`
carsus/data/basic_atomic_data.csv:14:4: F821 Undefined name `Al`
carsus/data/basic_atomic_data.csv:14:7: F821 Undefined name `Aluminium`
carsus/data/basic_atomic_data.csv:15:4: F821 Undefined name `Si`
carsus/data/basic_atomic_data.csv:15:7: F821 Undefined name `Silicon`
carsus/data/basic_atomic_data.csv:16:4: F821 Undefined name `P`
carsus/data/basic_atomic_data.csv:16:6: F821 Undefined name `Phosphorus`
carsus/data/basic_atomic_data.csv:17:4: F821 Undefined name `S`
carsus/data/basic_atomic_data.csv:17:6: F821 Undefined name `Sulfur`
carsus/data/basic_atomic_data.csv:18:4: F821 Undefined name `Cl`
carsus/data/basic_atomic_data.csv:18:7: F821 Undefined name `Chlorine`
carsus/data/basic_atomic_data.csv:19:4: F821 Undefined name `Ar`
carsus/data/basic_atomic_data.csv:19:7: F821 Undefined name `Argon`
carsus/data/basic_atomic_data.csv:20:4: F821 Undefined name `K`
carsus/data/basic_atomic_data.csv:20:6: F821 Undefined name `Potassium`
carsus/data/basic_atomic_data.csv:21:4: F821 Undefined name `Ca`
carsus/data/basic_atomic_data.csv:21:7: F821 Undefined name `Calcium`
carsus/data/basic_atomic_data.csv:22:4: F821 Undefined name `Sc`
carsus/data/basic_atomic_data.csv:22:7: F821 Undefined name `Scandium`
carsus/data/basic_atomic_data.csv:23:4: F821 Undefined name `Ti`
carsus/data/basic_atomic_data.csv:23:7: F821 Undefined name `Titanium`
carsus/data/basic_atomic_data.csv:24:4: F821 Undefined name `V`
carsus/data/basic_atomic_data.csv:24:6: F821 Undefined name `Vanadium`
carsus/data/basic_atomic_data.csv:25:4: F821 Undefined name `Cr`
carsus/data/basic_atomic_data.csv:25:7: F821 Undefined name `Chromium`
carsus/data/basic_atomic_data.csv:26:4: F821 Undefined name `Mn`
carsus/data/basic_atomic_data.csv:26:7: F821 Undefined name `Manganese`
carsus/data/basic_atomic_data.csv:27:4: F821 Undefined name `Fe`
carsus/data/basic_atomic_data.csv:27:7: F821 Undefined name `Iron`
carsus/data/basic_atomic_data.csv:28:4: F821 Undefined name `Co`
carsus/data/basic_atomic_data.csv:28:7: F821 Undefined name `Cobalt`
carsus/data/basic_atomic_data.csv:29:4: F821 Undefined name `Ni`
carsus/data/basic_atomic_data.csv:29:7: F821 Undefined name `Nickel`
carsus/data/basic_atomic_data.csv:30:4: F821 Undefined name `Cu`
carsus/data/basic_atomic_data.csv:30:7: F821 Undefined name `Copper`
carsus/data/basic_atomic_data.csv:31:4: F821 Undefined name `Zn`
carsus/data/basic_atomic_data.csv:31:7: F821 Undefined name `Zinc`
carsus/data/basic_atomic_data.csv:32:4: F821 Undefined name `Ga`
carsus/data/basic_atomic_data.csv:32:7: F821 Undefined name `Gallium`
carsus/data/basic_atomic_data.csv:33:4: F821 Undefined name `Ge`
carsus/data/basic_atomic_data.csv:33:7: F821 Undefined name `Germanium`
carsus/data/basic_atomic_data.csv:34:4: F821 Undefined name `As`
carsus/data/basic_atomic_data.csv:34:7: F821 Undefined name `Arsenic`
carsus/data/basic_atomic_data.csv:35:4: F821 Undefined name `Se`
carsus/data/basic_atomic_data.csv:35:7: F821 Undefined name `Selenium`
carsus/data/basic_atomic_data.csv:36:4: F821 Undefined name `Br`
carsus/data/basic_atomic_data.csv:36:7: F821 Undefined name `Bromine`
carsus/data/basic_atomic_data.csv:37:4: F821 Undefined name `Kr`
carsus/data/basic_atomic_data.csv:37:7: F821 Undefined name `Krypton`
carsus/data/basic_atomic_data.csv:38:4: F821 Undefined name `Rb`
carsus/data/basic_atomic_data.csv:38:7: F821 Undefined name `Rubidium`
carsus/data/basic_atomic_data.csv:39:4: F821 Undefined name `Sr`
carsus/data/basic_atomic_data.csv:39:7: F821 Undefined name `Strontium`
carsus/data/basic_atomic_data.csv:40:4: F821 Undefined name `Y`
carsus/data/basic_atomic_data.csv:40:6: F821 Undefined name `Yttrium`
carsus/data/basic_atomic_data.csv:41:4: F821 Undefined name `Zr`
carsus/data/basic_atomic_data.csv:41:7: F821 Undefined name `Zirconium`
carsus/data/basic_atomic_data.csv:42:4: F821 Undefined name `Nb`
carsus/data/basic_atomic_data.csv:42:7: F821 Undefined name `Niobium`
carsus/data/basic_atomic_data.csv:43:4: F821 Undefined name `Mo`
carsus/data/basic_atomic_data.csv:43:7: F821 Undefined name `Molybdenum`
carsus/data/basic_atomic_data.csv:44:4: F821 Undefined name `Tc`
carsus/data/basic_atomic_data.csv:44:7: F821 Undefined name `Technetium`
carsus/data/basic_atomic_data.csv:45:4: F821 Undefined name `Ru`
carsus/data/basic_atomic_data.csv:45:7: F821 Undefined name `Ruthenium`
carsus/data/basic_atomic_data.csv:46:4: F821 Undefined name `Rh`
carsus/data/basic_atomic_data.csv:46:7: F821 Undefined name `Rhodium`
carsus/data/basic_atomic_data.csv:47:4: F821 Undefined name `Pd`
carsus/data/basic_atomic_data.csv:47:7: F821 Undefined name `Palladium`
carsus/data/basic_atomic_data.csv:48:4: F821 Undefined name `Ag`
carsus/data/basic_atomic_data.csv:48:7: F821 Undefined name `Silver`
carsus/data/basic_atomic_data.csv:49:4: F821 Undefined name `Cd`
carsus/data/basic_atomic_data.csv:49:7: F821 Undefined name `Cadmium`
carsus/data/basic_atomic_data.csv:50:4: F821 Undefined name `In`
carsus/data/basic_atomic_data.csv:50:7: F821 Undefined name `Indium`
carsus/data/basic_atomic_data.csv:51:4: F821 Undefined name `Sn`
carsus/data/basic_atomic_data.csv:51:7: F821 Undefined name `Tin`
carsus/data/basic_atomic_data.csv:52:4: F821 Undefined name `Sb`
carsus/data/basic_atomic_data.csv:52:7: F821 Undefined name `Antimony`
carsus/data/basic_atomic_data.csv:53:4: F821 Undefined name `Te`
carsus/data/basic_atomic_data.csv:53:7: F821 Undefined name `Tellurium`
carsus/data/basic_atomic_data.csv:54:4: F821 Undefined name `I`
carsus/data/basic_atomic_data.csv:54:6: F821 Undefined name `Iodine`
carsus/data/basic_atomic_data.csv:55:4: F821 Undefined name `Xe`
carsus/data/basic_atomic_data.csv:55:7: F821 Undefined name `Xenon`
carsus/data/basic_atomic_data.csv:56:4: F821 Undefined name `Cs`
carsus/data/basic_atomic_data.csv:56:7: F821 Undefined name `Caesium`
carsus/data/basic_atomic_data.csv:57:4: F821 Undefined name `Ba`
carsus/data/basic_atomic_data.csv:57:7: F821 Undefined name `Barium`
carsus/data/basic_atomic_data.csv:58:4: F821 Undefined name `La`
carsus/data/basic_atomic_data.csv:58:7: F821 Undefined name `Lanthanum`
carsus/data/basic_atomic_data.csv:59:4: F821 Undefined name `Ce`
carsus/data/basic_atomic_data.csv:59:7: F821 Undefined name `Cerium`
carsus/data/basic_atomic_data.csv:60:4: F821 Undefined name `Pr`
carsus/data/basic_atomic_data.csv:60:7: F821 Undefined name `Praseodymium`
carsus/data/basic_atomic_data.csv:61:4: F821 Undefined name `Nd`
carsus/data/basic_atomic_data.csv:61:7: F821 Undefined name `Neodymium`
carsus/data/basic_atomic_data.csv:62:4: F821 Undefined name `Pm`
carsus/data/basic_atomic_data.csv:62:7: F821 Undefined name `Promethium`
carsus/data/basic_atomic_data.csv:63:4: F821 Undefined name `Sm`
carsus/data/basic_atomic_data.csv:63:7: F821 Undefined name `Samarium`
carsus/data/basic_atomic_data.csv:64:4: F821 Undefined name `Eu`
carsus/data/basic_atomic_data.csv:64:7: F821 Undefined name `Europium`
carsus/data/basic_atomic_data.csv:65:4: F821 Undefined name `Gd`
carsus/data/basic_atomic_data.csv:65:7: F821 Undefined name `Gadolinium`
carsus/data/basic_atomic_data.csv:66:4: F821 Undefined name `Tb`
carsus/data/basic_atomic_data.csv:66:7: F821 Undefined name `Terbium`
carsus/data/basic_atomic_data.csv:67:4: F821 Undefined name `Dy`
carsus/data/basic_atomic_data.csv:67:7: F821 Undefined name `Dysprosium`
carsus/data/basic_atomic_data.csv:68:4: F821 Undefined name `Ho`
carsus/data/basic_atomic_data.csv:68:7: F821 Undefined name `Holmium`
carsus/data/basic_atomic_data.csv:69:4: F821 Undefined name `Er`
carsus/data/basic_atomic_data.csv:69:7: F821 Undefined name `Erbium`
carsus/data/basic_atomic_data.csv:70:4: F821 Undefined name `Tm`
carsus/data/basic_atomic_data.csv:70:7: F821 Undefined name `Thulium`
carsus/data/basic_atomic_data.csv:71:4: F821 Undefined name `Yb`
carsus/data/basic_atomic_data.csv:71:7: F821 Undefined name `Ytterbium`
carsus/data/basic_atomic_data.csv:72:4: F821 Undefined name `Lu`
carsus/data/basic_atomic_data.csv:72:7: F821 Undefined name `Lutetium`
carsus/data/basic_atomic_data.csv:73:4: F821 Undefined name `Hf`
carsus/data/basic_atomic_data.csv:73:7: F821 Undefined name `Hafnium`
carsus/data/basic_atomic_data.csv:74:4: F821 Undefined name `Ta`
carsus/data/basic_atomic_data.csv:74:7: F821 Undefined name `Tantalum`
carsus/data/basic_atomic_data.csv:75:4: F821 Undefined name `W`
carsus/data/basic_atomic_data.csv:75:6: F821 Undefined name `Tungsten`
carsus/data/basic_atomic_data.csv:76:4: F821 Undefined name `Re`
carsus/data/basic_atomic_data.csv:76:7: F821 Undefined name `Rhenium`
carsus/data/basic_atomic_data.csv:77:4: F821 Undefined name `Os`
carsus/data/basic_atomic_data.csv:77:7: F821 Undefined name `Osmium`
carsus/data/basic_atomic_data.csv:78:4: F821 Undefined name `Ir`
carsus/data/basic_atomic_data.csv:78:7: F821 Undefined name `Iridium`
carsus/data/basic_atomic_data.csv:79:4: F821 Undefined name `Pt`
carsus/data/basic_atomic_data.csv:79:7: F821 Undefined name `Platinum`
carsus/data/basic_atomic_data.csv:80:4: F821 Undefined name `Au`
carsus/data/basic_atomic_data.csv:80:7: F821 Undefined name `Gold`
carsus/data/basic_atomic_data.csv:81:4: F821 Undefined name `Hg`
carsus/data/basic_atomic_data.csv:81:7: F821 Undefined name `Mercury`
carsus/data/basic_atomic_data.csv:82:4: F821 Undefined name `Tl`
carsus/data/basic_atomic_data.csv:82:7: F821 Undefined name `Thallium`
carsus/data/basic_atomic_data.csv:83:4: F821 Undefined name `Pb`
carsus/data/basic_atomic_data.csv:83:7: F821 Undefined name `Lead`
carsus/data/basic_atomic_data.csv:84:4: F821 Undefined name `Bi`
carsus/data/basic_atomic_data.csv:84:7: F821 Undefined name `Bismuth`
carsus/data/basic_atomic_data.csv:85:4: F821 Undefined name `Po`
carsus/data/basic_atomic_data.csv:85:7: F821 Undefined name `Polonium`
carsus/data/basic_atomic_data.csv:86:4: F821 Undefined name `At`
carsus/data/basic_atomic_data.csv:86:7: F821 Undefined name `Astatine`
carsus/data/basic_atomic_data.csv:87:4: F821 Undefined name `Rn`
carsus/data/basic_atomic_data.csv:87:7: F821 Undefined name `Radon`
carsus/data/basic_atomic_data.csv:88:4: F821 Undefined name `Fr`
carsus/data/basic_atomic_data.csv:88:7: F821 Undefined name `Francium`
carsus/data/basic_atomic_data.csv:89:4: F821 Undefined name `Ra`
carsus/data/basic_atomic_data.csv:89:7: F821 Undefined name `Radium`
carsus/data/basic_atomic_data.csv:90:4: F821 Undefined name `Ac`
carsus/data/basic_atomic_data.csv:90:7: F821 Undefined name `Actinium`
carsus/data/basic_atomic_data.csv:91:4: F821 Undefined name `Th`
carsus/data/basic_atomic_data.csv:91:7: F821 Undefined name `Thorium`
carsus/data/basic_atomic_data.csv:92:4: F821 Undefined name `Pa`
carsus/data/basic_atomic_data.csv:92:7: F821 Undefined name `Protactinium`
carsus/data/basic_atomic_data.csv:93:4: F821 Undefined name `U`
carsus/data/basic_atomic_data.csv:93:6: F821 Undefined name `Uranium`
carsus/data/basic_atomic_data.csv:94:4: F821 Undefined name `Np`
carsus/data/basic_atomic_data.csv:94:7: F821 Undefined name `Neptunium`
carsus/data/basic_atomic_data.csv:95:4: F821 Undefined name `Pu`
carsus/data/basic_atomic_data.csv:95:7: F821 Undefined name `Plutonium`
carsus/data/basic_atomic_data.csv:96:4: F821 Undefined name `Am`
carsus/data/basic_atomic_data.csv:96:7: F821 Undefined name `Americium`
carsus/data/basic_atomic_data.csv:97:4: F821 Undefined name `Cm`
carsus/data/basic_atomic_data.csv:97:7: F821 Undefined name `Curium`
carsus/data/basic_atomic_data.csv:98:4: F821 Undefined name `Bk`
carsus/data/basic_atomic_data.csv:98:7: F821 Undefined name `Berkelium`
carsus/data/basic_atomic_data.csv:99:4: F821 Undefined name `Cf`
carsus/data/basic_atomic_data.csv:99:7: F821 Undefined name `Californium`
carsus/data/basic_atomic_data.csv:100:4: F821 Undefined name `Es`
carsus/data/basic_atomic_data.csv:100:7: F821 Undefined name `Einsteinium`
carsus/data/basic_atomic_data.csv:101:5: F821 Undefined name `Fm`
carsus/data/basic_atomic_data.csv:101:8: F821 Undefined name `Fermium`
carsus/data/basic_atomic_data.csv:102:5: F821 Undefined name `Md`
carsus/data/basic_atomic_data.csv:102:8: F821 Undefined name `Mendelevium`
carsus/data/basic_atomic_data.csv:103:5: F821 Undefined name `No`
carsus/data/basic_atomic_data.csv:103:8: F821 Undefined name `Nobelium`
carsus/data/basic_atomic_data.csv:104:5: F821 Undefined name `Lr`
carsus/data/basic_atomic_data.csv:104:8: F821 Undefined name `Lawrencium`
carsus/data/basic_atomic_data.csv:105:5: F821 Undefined name `Rf`
carsus/data/basic_atomic_data.csv:105:8: F821 Undefined name `Rutherfordium`
carsus/data/basic_atomic_data.csv:106:5: F821 Undefined name `Db`
carsus/data/basic_atomic_data.csv:106:8: F821 Undefined name `Dubnium`
carsus/data/basic_atomic_data.csv:107:5: F821 Undefined name `Sg`
carsus/data/basic_atomic_data.csv:107:8: F821 Undefined name `Seaborgium`
carsus/data/basic_atomic_data.csv:108:5: F821 Undefined name `Bh`
carsus/data/basic_atomic_data.csv:108:8: F821 Undefined name `Bohrium`
carsus/data/basic_atomic_data.csv:109:5: F821 Undefined name `Hs`
carsus/data/basic_atomic_data.csv:109:8: F821 Undefined name `Hassium`
carsus/data/basic_atomic_data.csv:110:5: F821 Undefined name `Mt`
carsus/data/basic_atomic_data.csv:110:8: F821 Undefined name `Meitnerium`
carsus/data/basic_atomic_data.csv:111:5: F821 Undefined name `Ds`
carsus/data/basic_atomic_data.csv:111:8: F821 Undefined name `Darmstadtium`
carsus/data/basic_atomic_data.csv:112:5: F821 Undefined name `Rg`
carsus/data/basic_atomic_data.csv:112:8: F821 Undefined name `Roentgenium`
carsus/data/basic_atomic_data.csv:113:5: F821 Undefined name `Cn`
carsus/data/basic_atomic_data.csv:113:8: F821 Undefined name `Copernicium`
carsus/data/basic_atomic_data.csv:114:5: F821 Undefined name `Uut`
carsus/data/basic_atomic_data.csv:114:9: F821 Undefined name `Ununtrium`
carsus/data/basic_atomic_data.csv:115:5: F821 Undefined name `Fl`
carsus/data/basic_atomic_data.csv:115:8: F821 Undefined name `Flerovium`
carsus/data/basic_atomic_data.csv:116:5: F821 Undefined name `Uup`
carsus/data/basic_atomic_data.csv:116:9: F821 Undefined name `Ununpentium`
carsus/data/basic_atomic_data.csv:117:5: F821 Undefined name `Lv`
carsus/data/basic_atomic_data.csv:117:8: F821 Undefined name `Livermorium`
carsus/data/basic_atomic_data.csv:118:5: F821 Undefined name `Uus`
carsus/data/basic_atomic_data.csv:118:9: F821 Undefined name `Ununseptium`
carsus/data/basic_atomic_data.csv:119:5: F821 Undefined name `Uuo`
carsus/data/basic_atomic_data.csv:119:9: F821 Undefined name `Ununoctium`
carsus/io/atom_data_compare.py:28:8: E712 Avoid equality comparisons to `True`; use `if val:` for truth checks
carsus/io/atom_data_compare.py:256:27: E712 Avoid inequality comparisons to `True`; use `if not merged_df[column]:` for false checks
carsus/io/atom_data_compare.py:399:17: E712 Avoid equality comparisons to `False`; use `if not self.comparison_table.match:` for false checks
carsus/io/cmfgen/base.py:14:1: F403 `from .util import *` used; unable to detect undefined names
carsus/io/cmfgen/base.py:34:18: F405 `parse_header` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:35:23: F405 `find_row` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:55:26: F405 `find_row` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:107:18: F405 `parse_header` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:108:23: F405 `find_row` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:159:35: F405 `to_float` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:160:35: F405 `to_float` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:181:18: F405 `parse_header` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:182:23: F405 `find_row` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:193:18: F405 `find_row` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:199:26: F405 `find_row` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:204:44: F405 `to_float` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:220:39: F405 `to_float` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:284:67: F405 `to_float` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:291:41: F405 `to_float` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:303:18: F405 `parse_header` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:304:14: F405 `open_cmfgen_file` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:358:18: F405 `parse_header` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:368:23: F405 `find_row` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:377:20: E741 Ambiguous variable name: `l`
carsus/io/cmfgen/base.py:405:12: E741 Ambiguous variable name: `l`
carsus/io/cmfgen/base.py:452:12: E741 Ambiguous variable name: `l`
carsus/io/cmfgen/base.py:571:25: F405 `CMFGEN_ATOM_DICT` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:615:25: E741 Ambiguous variable name: `l`
carsus/io/cmfgen/base.py:686:21: F405 `HC_IN_EV_ANGSTROM` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:686:62: F405 `RYD_TO_EV` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:689:42: F405 `CrossSectionType` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:690:35: F405 `get_null_phixs_table` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:693:21: F405 `CrossSectionType` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:694:21: F405 `CrossSectionType` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:695:21: F405 `CrossSectionType` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:706:21: F405 `CrossSectionType` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:707:21: F405 `CrossSectionType` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:719:39: F405 `get_null_phixs_table` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:722:39: F405 `get_seaton_phixs_table` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:726:44: F405 `CrossSectionType` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:736:43: F405 `get_hydrogenic_n_phixs_table` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:746:21: F405 `CrossSectionType` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:747:21: F405 `CrossSectionType` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:759:35: F405 `get_hydrogenic_nl_phixs_table` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:766:44: F405 `CrossSectionType` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:775:35: F405 `get_opproject_phixs_table` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:779:44: F405 `CrossSectionType` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:788:35: F405 `get_hummer_phixs_table` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:792:44: F405 `CrossSectionType` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:801:35: F405 `get_vy95_phixs_table` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:805:44: F405 `CrossSectionType` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:815:39: F405 `get_leibowitz_phixs_table` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:823:39: F405 `get_null_phixs_table` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:915:42: F405 `HC_IN_EV_ANGSTROM` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:918:46: F405 `RYD_TO_EV` may be undefined, or defined from star imports
carsus/io/cmfgen/base.py:923:29: E741 Ambiguous variable name: `l`
carsus/io/cmfgen/base.py:926:35: F405 `RYD_TO_EV` may be undefined, or defined from star imports
carsus/io/nndc/base.py:10:1: E402 Module level import not at top of file
carsus/io/nndc/base.py:11:1: E402 Module level import not at top of file
carsus/io/nndc/base.py:13:1: E402 Module level import not at top of file
carsus/io/nndc/base.py:17:1: E402 Module level import not at top of file
carsus/io/nndc/base.py:18:1: E402 Module level import not at top of file
carsus/io/nndc/base.py:21:1: E402 Module level import not at top of file
carsus/io/nndc/base.py:22:1: E402 Module level import not at top of file
carsus/io/tests/test_cmfgen.py:16:1: F403 `from carsus.io.cmfgen.util import *` used; unable to detect undefined names
carsus/io/tests/test_cmfgen.py:170:19: F405 `get_seaton_phixs_table` may be undefined, or defined from star imports
carsus/io/tests/test_cmfgen.py:189:32: F405 `get_hydrogenic_n_phixs_table` may be undefined, or defined from star imports
carsus/io/tests/test_cmfgen.py:211:19: F405 `get_hydrogenic_nl_phixs_table` may be undefined, or defined from star imports
carsus/io/tests/test_cmfgen.py:228:19: F405 `get_opproject_phixs_table` may be undefined, or defined from star imports
carsus/io/tests/test_cmfgen.py:237:19: F405 `get_hummer_phixs_table` may be undefined, or defined from star imports
carsus/io/tests/test_cmfgen.py:261:19: F405 `get_vy95_phixs_table` may be undefined, or defined from star imports
carsus/io/tests/test_cmfgen.py:273:19: F405 `get_null_phixs_table` may be undefined, or defined from star imports
carsus/io/vald/vald.py:184:37: E712 Avoid equality comparisons to `False`; use `if not self._stellar_linelist:` for false checks
docs/conf.py:61:1: F405 `exclude_patterns` may be undefined, or defined from star imports
docs/conf.py:62:1: F405 `exclude_patterns` may be undefined, or defined from star imports
docs/conf.py:63:1: F405 `exclude_patterns` may be undefined, or defined from star imports
docs/conf.py:68:1: F405 `rst_epilog` may be undefined, or defined from star imports
docs/conf.py:133:1: E402 Module level import not at top of file
Found 319 errors.
No fixes available (4 hidden fixes can be enabled with the `--unsafe-fixes` option).

Nitish-Naik · 2025-03-06T07:06:24Z

@jvshields @andrewfullard could you please review this ?
Eagerly waiting for your response..
Thanks in advance.
Nitish

Nitish-Naik · 2025-03-06T07:21:11Z

@jvshields , @andrewfullard

can you please also recheck this and update it. It will be further useful for the contributors
Thanks in advance,
Nitish

andrewfullard

Please make sure tests pass. We will handle the docs pipeline issue.

jvshields · 2025-03-06T20:05:43Z

In the files where os is no longer needed for anything, please remove the import. If you have ruff set up as a linter, it can check for unused imports.

review-notebook-app · 2025-03-07T04:23:30Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Nitish-Naik · 2025-03-07T04:28:37Z

@jvshields @andrewfullard can you please review it again
Eagerly waiting for you response.
Nitish

carsus/data/basic_atomic_data.csv

jvshields · 2025-03-07T16:28:33Z

Sorry, I should have specified. It's much easier to only run ruff on the files you've directly affected. We have been meaning to standardize formatting of carsus as a whole, but many files are not ruff compliant currently. I actually think this is mostly pretty good, and you might be able to fix the tests just by reverting the basic_atom_data.csv file.

Nitish-Naik · 2025-03-08T08:13:37Z

@andrewfullard sir removed unnecessary formatting is removed..
Can you please review it again.
Thanks in advance
Eagerly waiting for your response
Nitish

Nitish-Naik · 2025-03-09T10:19:09Z

@andrewfullard , @atharva-2001 can you please review it again

wkerzendorf · 2025-03-10T15:03:14Z

@Nitish-Naik tests are failing - please fix.

Nitish-Naik · 2025-03-10T17:13:10Z

@wkerzendorf errors are resolved, can you please check them.

jvshields

Happy with this, but I opened issue #435 to note that we're doing a lot of string casting that might not be the best solution.

Nitish-Naik · 2025-03-20T16:36:49Z

@wkerzendorf @jvshields @andrewfullard when this will be merged
Nitish

Refactored os.path to pathlib in CARSUS (#388)

fe63d89

andrewfullard requested review from atharva-2001 and andrewfullard March 6, 2025 15:01

andrewfullard requested changes Mar 6, 2025

View reviewed changes

Removed unused os imports and ensured tests pass

edda1fe

Nitish-Naik requested a review from andrewfullard March 7, 2025 06:05

andrewfullard reviewed Mar 7, 2025

View reviewed changes

carsus/data/basic_atomic_data.csv Show resolved Hide resolved

removed unnecessary formatting

6ac51c1

Nitish-Naik requested a review from andrewfullard March 8, 2025 08:13

andrewfullard approved these changes Mar 10, 2025

View reviewed changes

wkerzendorf self-requested a review March 10, 2025 15:00

wkerzendorf approved these changes Mar 10, 2025

View reviewed changes

andrewfullard requested review from andrewfullard and wkerzendorf March 10, 2025 15:02

errors resolved

49eb6d1

jvshields mentioned this pull request Mar 11, 2025

Investigate better use of pathlib in parsers #435

Open

jvshields approved these changes Mar 11, 2025

View reviewed changes

andrewfullard approved these changes Mar 11, 2025

View reviewed changes

Nitish-Naik marked this pull request as draft March 18, 2025 04:20

Nitish-Naik marked this pull request as ready for review March 18, 2025 04:20

jvshields merged commit 9e6f9d1 into tardis-sn:master Mar 27, 2025
7 of 9 checks passed

Uh oh!

Refactored os.path to pathlib in CARSUS (#388) #432

Refactored os.path to pathlib in CARSUS (#388) #432

Uh oh!

Conversation

Nitish-Naik commented Mar 6, 2025

📝 Description

📌 Resources

🚦 Testing

☑️ Checklist

Uh oh!

github-actions bot commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nitish-Naik commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nitish-Naik commented Mar 6, 2025

Uh oh!

andrewfullard left a comment

Choose a reason for hiding this comment

Uh oh!

jvshields commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

review-notebook-app bot commented Mar 7, 2025

Uh oh!

Nitish-Naik commented Mar 7, 2025

Uh oh!

Uh oh!

jvshields commented Mar 7, 2025

Uh oh!

Nitish-Naik commented Mar 8, 2025

Uh oh!

Nitish-Naik commented Mar 9, 2025

Uh oh!

wkerzendorf commented Mar 10, 2025

Uh oh!

Nitish-Naik commented Mar 10, 2025

Uh oh!

jvshields left a comment

Choose a reason for hiding this comment

Uh oh!

Nitish-Naik commented Mar 20, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 6, 2025 •

edited

Loading

Nitish-Naik commented Mar 6, 2025 •

edited

Loading

jvshields commented Mar 6, 2025 •

edited

Loading