Close HDF files from RegressionData objects

tardis-sn · Oct 16, 2024 · f379754 · f379754
1 parent aac5a99
commit f379754
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 2 deletions.
diff --git a/tardis/spectrum/tests/test_spectrum_solver.py b/tardis/spectrum/tests/test_spectrum_solver.py
@@ -34,7 +34,8 @@ def simulation(
         request.cls.regression_data = RegressionData(request)
         request.cls.regression_data.sync_hdf_store(simulation)
 
-        return simulation
+        yield simulation
+        request.cls.regression_data.close()
 
     def get_expected_data(self, key: str):
         return pd.read_hdf(self.regression_data.fpath, key)

diff --git a/tardis/tests/test_tardis_full.py b/tardis/tests/test_tardis_full.py
@@ -57,7 +57,8 @@ def simulation(
         request.cls.regression_data = RegressionData(request)
         request.cls.regression_data.sync_hdf_store(simulation)
 
-        return simulation
+        yield simulation
+        request.cls.regression_data.close()
 
     def get_expected_data(self, key: str):
         return pd.read_hdf(self.regression_data.fpath, key)

diff --git a/tardis/tests/test_tardis_full_formal_integral.py b/tardis/tests/test_tardis_full_formal_integral.py
@@ -74,6 +74,7 @@ def test_simulation(self, simulation, request):
         regression_data = RegressionData(request)
         container = SimulationContainer(simulation)
         regression_data.sync_hdf_store(container)
+        regression_data.close()
 
     def test_j_blue_estimators(self, simulation, request):
         regression_data = RegressionData(request)

diff --git a/tardis/visualization/tools/tests/test_liv_plot.py b/tardis/visualization/tools/tests/test_liv_plot.py
@@ -357,6 +357,7 @@ def test_generate_plot_mpl(
                             + str(index2)
                         ),
                     )
+        expected.close()
 
     def test_mpl_image(self, plotter_generate_plot_mpl, tmp_path, request):
         """
@@ -520,3 +521,4 @@ def test_generate_plot_ply(
                 rtol=0.3,
                 atol=3,
             )
+        expected.close()
diff --git a/tardis/visualization/tools/tests/test_sdec_plot.py b/tardis/visualization/tools/tests/test_sdec_plot.py
@@ -231,6 +231,7 @@ def test_calculate_plotting_data(
                 pd.testing.assert_frame_equal(
                     plot_object, expected.get(group + attribute_name)
                 )
+        expected.close()
 
     @pytest.fixture(scope="class", params=combinations)
     def plotter_generate_plot_mpl(self, request, observed_spectrum, plotter):
@@ -331,6 +332,7 @@ def test_generate_plot_mpl(
                             + str(index2)
                         ),
                     )
+        expected.close()
 
     @pytest.fixture(scope="class", params=combinations)
     def plotter_generate_plot_ply(self, request, observed_spectrum, plotter):
@@ -416,6 +418,8 @@ def test_generate_plot_mpl(
                 data.y, expected.get(group + "y").values.flatten()
             )
 
+        expected.close()
+
     def test_mpl_image(self, plotter_generate_plot_mpl, tmp_path, request):
         regression_data = RegressionData(request)
         fig, _ = plotter_generate_plot_mpl