Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transaction)!: allow multiple signers #1053

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jun 19, 2024

Description

Allow multiple signers for a transaction

Motivation and Context

This enables many use cases including paying for another user's fees (gasless) and invoking two or more components owned by different public keys in the same transaction.

It is possible for a party to remove all signatures but one and still have a valid transaction. In future, we'll add a final signature that includes all signatures in the preimage.

How Has This Been Tested?

Manually. TODO: Multiple signer integration test

What process can a PR reviewer use to test or verify this change?

Submit transactions requiring badges from multiple public keys

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

BREAKING CHANGE: wallet database changed, transaction struct changed

Copy link

github-actions bot commented Jun 19, 2024

Test Results (CI)

539 tests  +1   539 ✅ +1   1h 54m 29s ⏱️ - 26m 27s
 64 suites ±0     0 💤 ±0 
  2 files   ±0     0 ❌ ±0 

Results for commit b9c4f4e. ± Comparison against base commit 0ebb1fb.

This pull request removes 3 and adds 4 tests. Note that renamed tests count towards both.
tari_transaction ‑ transaction::export_bindings_substaterequirement
tari_transaction ‑ transaction::export_bindings_versionedsubstateid
tari_transaction ‑ transaction::tests::it_hashes_identically_to_a_substate_id
tari_dan_engine::account ‑ gasless
tari_transaction ‑ substate::export_bindings_substaterequirement
tari_transaction ‑ substate::export_bindings_versionedsubstateid
tari_transaction ‑ substate::tests::it_hashes_identically_to_a_substate_id

♻️ This comment has been updated with latest results.

@stringhandler stringhandler added this pull request to the merge queue Jun 27, 2024
Merged via the queue into tari-project:development with commit b98b1f8 Jun 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants