fix(consensus): dont transition to error state with invalid foreign proposal #927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix(consensus): dont transition to error state with invalid foreign proposal
test(consensus): fix flaky
foreign_block_distribution
testMotivation and Context
Invalid messages should not cause the state machine to transition to error.
foreign_block_distribution is often flaky in CI. Hopefully this will fix it 🤞
How Has This Been Tested?
Ran
foreign_block_distribution
What process can a PR reviewer use to test or verify this change?
CI
Breaking Changes