Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] ci(fix): possible add linux-riscv and windows-arm64 builds #6388

Closed
wants to merge 1 commit into from
Closed

[WIP] ci(fix): possible add linux-riscv and windows-arm64 builds #6388

wants to merge 1 commit into from

Conversation

leet4tari
Copy link
Contributor

@leet4tari leet4tari commented Jul 4, 2024 •
edited
Loading

Description
Progress toward builds for linux riscv64 and windows arm64, which currently fail on ring 0.16

Motivation and Context
Add more build options

How Has This Been Tested?
Builds locally, with updated deps, but still not rsicv/win-arm64 support. Docker arm64 breakage, still investigating.

What process can a PR reviewer use to test or verify this change?

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

Test Results (Integration tests)

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 1fbc9ec.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jul 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

Test Results (CI)

    3 files    129 suites   38m 55s ⏱️
1 303 tests 1 303 ✅ 0 💤 0 ❌
3 904 runs  3 904 ✅ 0 💤 0 ❌

Results for commit 1fbc9ec.

♻️ This comment has been updated with latest results.

@leet4tari leet4tari changed the title ci(fix): possible add linux-riscv and windows-arm64 builds [WIP] ci(fix): possible add linux-riscv and windows-arm64 builds Jul 4, 2024
@leet4tari
Copy link
Contributor Author

Still have a dependancy on ring v0.16, which does not support linux-risv64 nor windows-arm64.

ring v0.16.20
└── trust-dns-proto v0.23.2
    └── trust-dns-client v0.23.2
        └── tari_p2p v1.0.0-pre.15

Switching to rebranded Hickory DNS when PR hickory-dns/hickory-dns#2217 is merged, should drop the dependancy on ring v0.16.

@leet4tari
Copy link
Contributor Author

Progress update:
PR - hickory-dns/hickory-dns#2217 has been merged - awesome!
Awaiting the next release of hickory-dns, which looks to be about to happen.

Currently been tracked in hickory-dns/hickory-dns#2206

Once that is in place, we can further update and see what else needs work.

@ghpbot-tari-project ghpbot-tari-project added the CR-too_long Changes Requested - Your PR is too long label Aug 19, 2024
@leet4tari
switch to hickory-client/hickory-proto from trust-dns-client
1fbc9ec 
  and bump rustls/tokio-rustls/tonic/console-subscriber
@leet4tari leet4tari mentioned this pull request Oct 3, 2024
Open
@leet4tari
Copy link
Contributor Author

leet4tari commented Oct 8, 2024 •
edited
Loading

Superseded by #6611 and #6603 , closed.

@leet4tari leet4tari closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CR-too_long Changes Requested - Your PR is too long P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leet4tari @ghpbot-tari-project