feat(p2pool): add coinbase extra field to p2pool proto #6570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-coinbase-extra # Conflicts: # applications/minotari_merge_mining_proxy/src/block_template_protocol.rs # applications/minotari_miner/src/run_miner.rs
Test Results (Integration tests) 2 files 11 suites 32m 12s ⏱️ For more details on these failures, see this check. Results for commit 983eff7. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (CI) 3 files 129 suites 34m 10s ⏱️ Results for commit 983eff7. ♻️ This comment has been updated with latest results. |
stringhandler
previously approved these changes
Sep 23, 2024
SWvheerden
approved these changes
Sep 24, 2024
ghpbot-tari-project
removed
the
P-reviews_required
SWvheerden
pushed a commit
to SWvheerden/tari
that referenced
this pull request
Sep 24, 2024
…6570) Description --- Added an optional coinbase extra field when miners are asking for a new block from p2pool. Motivation and Context --- Until now, adding any custom coinbase extra data to coinbases was not supported by p2pool, so added the option. How Has This Been Tested? --- What process can a PR reviewer use to test or verify this change? --- Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an optional coinbase extra field when miners are asking for a new block from p2pool.
Motivation and Context
Until now, adding any custom coinbase extra data to coinbases was not supported by p2pool, so added the option.
How Has This Been Tested?
What process can a PR reviewer use to test or verify this change?
Breaking Changes