refactor: reduce code duplication and improve project structure#102
refactor: reduce code duplication and improve project structure#102palchhinparihar wants to merge 6 commits intotarinagarwal:mainfrom
Conversation
…hance/add-olive-theme-with-aos-animations
…hance/add-olive-theme-with-aos-animations
tarinagarwal
left a comment
There was a problem hiding this comment.
Hey @palchhinparihar, thanks for the PR!
A few issues here:
-
Theme changes should be in a separate PR - This PR includes the same olive theme changes from PR #84 (index.css, Navbar, Footer, LandingPage, AOS animations). Mixing theme changes with refactoring makes it hard to review and we can't merge an incomplete theme that only covers some pages.
-
RoadmapDetailPage is missing functionality - 569 lines deleted but only 44 added. The Tools tab, Certifications tab, Career Path tab, Best Practices, Common Pitfalls, and Project details sections are all gone. This removes actual features, not just refactors code.
-
AdminPanel also has significant deletions - 529 lines removed. Need to verify nothing important was lost.
-
ScrollToTop uses undefined colors -
bg-moss-accentandhover:bg-olive-primarywon't work without the full theme being applied.
Please:
- Remove all theme/styling changes (keep those in PR #84)
- Restore the removed functionality in RoadmapDetailPage
- Keep this PR focused only on actual refactoring (extracting reusable components, reducing duplication)
Hi, Palchhin here,
📝 Description
This PR focuses on refactoring the existing codebase to reduce repeated and duplicated logic across multiple files. The goal is to improve maintainability, readability, and scalability without altering any existing functionality or UI behavior.
Key refactoring efforts include:
This refactor lays a stronger foundation for future development and makes the project easier to debug, extend, and collaborate on.
🔗 Related Issue
Closes #89
🏷️ Type of Change
📸 Screenshots (if applicable)
N/A – No UI or visual changes were made as part of this refactor.
✅ Checklist
🧪 Testing
The application was tested locally to ensure no functional or behavioral changes were introduced.
📋 Additional Notes
SWOC 2026 Participant? Add
swoc2026label to your PR! 🎉Let me know for any changes.
Thank you.