Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept of changes #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Concept of changes #22

wants to merge 2 commits into from

Conversation

hvitis
Copy link
Collaborator

@hvitis hvitis commented Apr 21, 2023

This is just a concept of changes. (not tested and not fully implemented)

I'm mostly wondering about your idea that you mentioned in the Issue. I'm not sure about the sentbox. I see that there is a sender but only in Message model (which sometimes can be deleted as a first object by default?) Maybe that is why it could be OK just to add sent_by or created_by FK on the Thread model so that we can easily query when calling sentbox?

Also I changed the URLs to unify the structure and get rid of the words (We use HTTP methods). It could be unified even more. This way we know that the root is threads and we follow the convention for listing on root / etc.

Relates to.

@tarsil
Copy link
Owner

tarsil commented Apr 21, 2023

So the idea is simple. What is an inbox? The messages sent to someone or received. So basically we need to enable the flag or create a new one that tells exactly that. The relates model is the place where that can be checked. From and to user. Does this make sense?

@hvitis
Copy link
Collaborator Author

hvitis commented Apr 21, 2023

Yea, of course! Then I think I did it as you say. I will wait for your review. My next week is also busy so don't push yourself and take it easy!

Thanks a bunch!

@tarsil
Copy link
Owner

tarsil commented Apr 21, 2023

Are you not in a rush for this? Next week for sure we release and you become a maintainer. Amazing job what you did. Really. Congratulations

@hvitis
Copy link
Collaborator Author

hvitis commented Apr 21, 2023

I am for now still working on messaging dashboard in React. It will take me a couple of days. No worries. If we apply those ideas (urls, sentbox, docs) it would be a breaking change so it should be implemented with high quality & care.

@tarsil
Copy link
Owner

tarsil commented Apr 21, 2023

It's a deal. Thank you so much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants