Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a concept of changes. (not tested and not fully implemented)
I'm mostly wondering about your idea that you mentioned in the Issue. I'm not sure about the sentbox. I see that there is a sender but only in
Message
model (which sometimes can be deleted as a first object by default?) Maybe that is why it could be OK just to add sent_by or created_by FK on the Thread model so that we can easily query when calling sentbox?Also I changed the URLs to unify the structure and get rid of the words (We use HTTP methods). It could be unified even more. This way we know that the root is threads and we follow the convention for listing on root / etc.
Relates to.