Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goal kanban ranking #3079

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Goal kanban ranking #3079

merged 1 commit into from
Oct 31, 2024

Conversation

tsumo
Copy link
Contributor

@tsumo tsumo commented Oct 29, 2024

PR includes

  • Feature

Related issues

QA Instructions, Screenshots, Recordings

@tsumo tsumo marked this pull request as ready for review October 29, 2024 22:34
LamaEats
LamaEats approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@LamaEats LamaEats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm
However, I would move all new rank queries outside the goal's router module in the goal's query module and ranking query module

trpc/utils.ts Show resolved Hide resolved
@9teen90nine 9teen90nine merged commit fdcec4a into main Oct 31, 2024
3 checks passed
@9teen90nine 9teen90nine deleted the goal-ranks branch October 31, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyet-ty nyet-ty nyet-ty approved these changes

@asabotovich asabotovich asabotovich approved these changes

@LamaEats LamaEats LamaEats approved these changes

@Katrin-kudryash Katrin-kudryash Awaiting requested review from Katrin-kudryash

@IgorGoryany IgorGoryany Awaiting requested review from IgorGoryany

@9teen90nine 9teen90nine Awaiting requested review from 9teen90nine 9teen90nine is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tsumo @LamaEats @asabotovich @nyet-ty @9teen90nine