fix(events-producer): serialize and deserialize custom events #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
commented
Dec 31, 2024
| case 'stalled': | ||
| case 'waiting': | ||
| case 'waiting-children': | ||
| break; |
There was a problem hiding this comment.
avoid to do a deserialization for these events that do not need it
There was a problem hiding this comment.
Fastest here would be to use a Set object that is global for this module and that provides fast check for membership.
roggervalf
force-pushed
the
event-producer-fix-args-stringify
branch
from
a2d6d5c to
115e528
Compare
manast
reviewed
Jan 11, 2025
| @@ -40,7 +40,7 @@ export class QueueEventsProducer extends QueueBase { | |||
| const args: any[] = ['MAXLEN', '~', maxEvents, '*', 'event', eventName]; | |||
|
|
|||
| for (const [key, value] of Object.entries(restArgs)) { | |||
| args.push(key, value); | |||
| args.push(key, JSON.stringify(value)); | |||
There was a problem hiding this comment.
I think we are digging ourselves more into this rabbit hole, as it would have been much simpler to just allow sending strings as payloads for the custom events and let the user serialize and deserialise as they see fit, this will never be satisfactory for all cases out there...
roggervalf
force-pushed
the
event-producer-fix-args-stringify
branch
from
115e528 to
23be50e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Enter your explanation here.
How
Enter the implementation details here.
Additional Notes (Optional)
Any extra info here.
Ignore events that do not need this deserialization as the ones that we handled internally in this package
ref #2984