Added on_send_error middleware hook #360
Open
+139
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s3rius
approved these changes
Nov 6, 2024
|
Can you please doc entry about this functionality in docs folder? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am currently working on a retrying feature to ensure the delivery of messages when the queue service is unstable. I found that it could be really helpful to have this
on_send_errorso that we can store the failed message and retry later.I've also added a
boolreturn to make it able to mute exceptions so that we don't have to try-catch the kicking everywhere.The execution order of
on_send_erroris reversed, just like what I suggested in #359 .Please let me know if you have some ideas, suggestions or concerns, and big thanks in advance!