Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Thermostat.md #1243

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Update Thermostat.md #1243

merged 2 commits into from
Nov 11, 2023

Conversation

KDMcMullan
Copy link
Contributor

Grammar corrections to clarify "bypass". Other simplifications.
Corrected default timeresetset value to match the suggested user_config_override.h.

Grammar corrections to clarify "bypass", also corrected default timeresetset value to match the suggested user_config_override.h
@KDMcMullan
Copy link
Contributor Author

KDMcMullan commented Jul 1, 2023

Just for clarity, the sentence "If the application requires to follow the command of the input once active (see bypass setup explained in previous section)." was the one I was targeting, but I did a couple of others, too. Have I done too much for a single change?
Grasping "bypass" and the polarity of cmnd/Tasmota_Name/INPUTSWITCHUSE were the things I struggled with most when exploring thermostat.

@blakadder
Copy link
Contributor

care to check the accuracy of these additions @arijav

@mendel5
Copy link
Contributor

mendel5 commented Nov 11, 2023

I think this is a useful change and would appreciate it if somebody could merge this pull request.

However, we need to consider the merge conflict that is caused by this change: #1295 Replace "f.e." with "e.g.,", see also https://github.com/tasmota/docs/commits/master/docs/Thermostat.md
So we just need to make sure to keep the e.g..

@barbudor barbudor merged commit a0a3195 into tasmota:master Nov 11, 2023
1 check passed
@mendel5
Copy link
Contributor

mendel5 commented Nov 11, 2023

Thank you!

@KDMcMullan KDMcMullan deleted the patch-1 branch November 13, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants