Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Displays.md #1399

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Update Displays.md #1399

merged 1 commit into from
Jul 14, 2024

Conversation

fb-pilot
Copy link
Contributor

@arendst arendst merged commit f5cce31 into tasmota:master Jul 14, 2024
1 check passed
@sfromis
Copy link
Collaborator

sfromis commented Jul 14, 2024

Why do you want to make those two links absolute, when the previous relative links (this format is used in all other docs links) are how it is supposed to work? Anyway, not long ago those two links were broken, I fixed them to the standard format, as used for other links.

IMO, this change should be reverted, without good reasons to do it.

@arendst
Copy link
Collaborator

arendst commented Jul 14, 2024

OK. I'll revert although the links then don't work for me.

@arendst
Copy link
Collaborator

arendst commented Jul 14, 2024

The reverted link https://tasmota.github.io/docs/Displays/Universal-Display-Driver/.md#universal-display-driver-udisplay doesn't work for me.

@sfromis
Copy link
Collaborator

sfromis commented Jul 14, 2024

Made another fix, the issue was having a slash after the page name, before the #. Tested to work, even if what's shown when hovering the links in a browser is what does not work in the md files.

@arendst
Copy link
Collaborator

arendst commented Jul 14, 2024

Yep. Verified. Works fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants