Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALL-2392 Added 'replaceable' way of tx preparation (RBF) for BTC and DOGE #890

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

alexloiko
Copy link
Member

No description provided.

@TatumBot
Copy link

@gitguardian
Copy link

gitguardian bot commented Aug 15, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
4757440 Generic High Entropy Secret 99a4b36 examples/doge-example/src/app/doge.tx.rbf.example.ts View secret
4757440 Generic High Entropy Secret 99a4b36 examples/btc-example/src/app/btc.tx.rbf.example.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@alexloiko alexloiko force-pushed the feature/ALL-2392-rbf-btc-based branch from 2a19801 to 99a4b36 Compare August 15, 2023 12:23
@alexloiko alexloiko changed the title ALL-2392 Added 'replaceable' body parameter for RBF for BTC, LTC and … ALL-2392 Added 'replaceable' way of tx preparation (RBF) for BTC and DOGE Aug 15, 2023
@alexloiko alexloiko merged commit 9f2ea3a into v2 Aug 15, 2023
0 of 2 checks passed
@alexloiko alexloiko deleted the feature/ALL-2392-rbf-btc-based branch August 15, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants