Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build stdlib on macOS #210

Merged
merged 6 commits into from
May 7, 2024
Merged

build stdlib on macOS #210

merged 6 commits into from
May 7, 2024

Conversation

tayloraswift
Copy link
Owner

No description provided.

@tayloraswift tayloraswift marked this pull request as ready for review May 7, 2024 02:01
@tayloraswift tayloraswift changed the title test SSGC on macOS build stdlib on macOS May 7, 2024
@tayloraswift
Copy link
Owner Author

so there seem to be two issues at play here

  1. on macOS, Objective C symbols can have multiple parents. we don’t seem to be relying on this assumption for anything important, so we can just disable this check for Objective C symbols with 2bca0de
  2. for some reason, we can’t dump the symbol graph for Swift NIO on macOS. this won’t affect anyone unless they are trying to contribute to Swift NIO, but it is preventing the CI pipeline from passing

@tayloraswift
Copy link
Owner Author

i’ve split off #211 into a separate issue and temporarily disabled the swift-nio test on macOS.

@tayloraswift tayloraswift merged commit 3c82e60 into master May 7, 2024
2 checks passed
@tayloraswift tayloraswift deleted the ssgc-macos branch May 7, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tayloraswift