-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tox ci #10
Merged
Merged
Fix tox ci #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
===========================================
+ Coverage 99.52% 100.00% +0.47%
===========================================
Files 12 12
Lines 212 212
===========================================
+ Hits 211 212 +1
+ Misses 1 0 -1 ☔ View full report in Codecov by Sentry. |
Closed
tbrlpld
force-pushed
the
improve-docs
branch
2 times, most recently
from
January 27, 2024 17:15
d563270
to
3ebda1b
Compare
This reverts commit b8a7e67.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the tox configuration in CI.
The
gh-actions:env
section was not needed. It actually led to not all environment combinations being run and it also meant that the dependency installation did not happen in the expected environments.See: ymyzk/tox-gh-actions#193
One symptom of the above was the we never actually tested with Django 3.2 in CI (which was noticed because it led to errors when running tox locally, where the environments were working just fine). Now we are properly testing Django 3.2 on CI as well.
Another symptom of the above was that we needed to redefine
coverage
in thetox.ini
dependencies although it is already listed in thetesting
dependencies inpyproject.toml
.The redefinition of
coverage
was also solved (before the above complete solution to the environment issue) previously by switching fromskipsdist
,usedevelop
and a custominstall_command
to the more modern tox config optionsextras = testing
andpackage = editable
.Also bumps CI versions to not use deprecated Node version 16 anymore.