Skip to content

Conversation

@catamorphism
Copy link
Contributor

Explain why the ISODateWithinLimits check is necessary.

Explain why the ISODateWithinLimits check is necessary.
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.67%. Comparing base (4197642) to head (57e18ca).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3192   +/-   ##
=======================================
  Coverage   96.67%   96.67%           
=======================================
  Files          22       22           
  Lines       10357    10357           
  Branches     1859     1859           
=======================================
  Hits        10013    10013           
  Misses        294      294           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't clock this earlier but now that I think about it some more, this check should probably turn into an assertion after a table of reference years is added in tc39/proposal-intl-era-monthcode#60. Then the note will no longer be necessary.

Let's hold off on this until that issue is solved and see if this still applies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants