Temporal: Add tests for a non-ISO-calendar edge case with leap years and differencing #4636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Depends on spec PR tc39/proposal-temporal#3176 |
ptomato
requested changes
Nov 5, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
- Should probably include more test cases (like the ones for durations longer than a year that I wrote in tc39/proposal-temporal#3176 (review))
- Should be expanded to PlainDateTime and ZonedDateTime
- Is it possible to trigger the bug with PlainYearMonth? If so we should add those as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.