Skip to content

Conversation

@gibson042
Copy link
Member

See #4623 (comment) and https://github.com/tc39/test262/actions/runs/18957730032/job/54138279811?pr=4623

Run echo 'New or modified test files:'
New or modified test files:
test/built-ins/ThrowTypeError/distinct-cross-realm.js
========================================
 extract phase
----------------------------------------
========================================
 compile phase
----------------------------------------
========================================
 build-cfg phase
----------------------------------------
========================================
 test262-test phase
----------------------------------------
[NotSupported] feature/$262
Error: Process completed with exit code 123.

@gibson042 gibson042 requested a review from a team as a code owner November 12, 2025 21:47
@ptomato
Copy link
Contributor

ptomato commented Nov 13, 2025

@gibson042 can this be closed now that #4658 has landed?

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 14, 2025

It's unclear to me whether the other PR solved the issue by implementing the relevant feature and not triggering the error message or by handling the error message without failing the job. That said, the code here looks somewhat brittle.

@gibson042
Copy link
Member Author

I'm fine with relying upon the changes of es-meta/esmeta#319 .

@gibson042 gibson042 closed this Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants