Add tests for Generator.prototype.return() with yield in finally#4939
Open
Add tests for Generator.prototype.return() with yield in finally#4939
Conversation
Tighten spec assertions for completion behavior after throws in finally and for return value propagation through yield* delegation during return.
cfed5ef to
7cad34b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4937
These tests cover the scenario where generator.return() is called while the generator is paused in a try block, and the finally block contains a yield statement. The existing tests don't cover this path:
New tests:
All tests validated against V8 (Node.js), SpiderMonkey (Firefox), and JavaScriptCore (Safari).
This coverage gap was discovered while fixing a bug in Sobek (grafana/sobek#115), a Go-based JavaScript runtime.